2022-06-21 10:22:54

by Jiang Jian

Subject: [PATCH] mmc: host: dw_mmc: remove unexpected word "the"

there is an unexpected word "the" in the comments that need to be removed

* command hasn't already completed (indicating the the irq

Signed-off-by: Jiang Jian <[email protected]>
---
drivers/mmc/host/dw_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 581614196a84..7f00d7d7e35e 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -1363,7 +1363,7 @@ static void __dw_mci_start_request(struct dw_mci *host,
* is just about to roll over.
*
* We do this whole thing under spinlock and only if the
- * command hasn't already completed (indicating the the irq
+ * command hasn't already completed (indicating the irq
* already ran so we don't want the timeout).
*/
spin_lock_irqsave(&host->irq_lock, irqflags);
--
2.17.1

2022-06-23 12:39:35

by Ulf Hansson

Subject: Re: [PATCH] mmc: host: dw_mmc: remove unexpected word "the"

On Tue, 21 Jun 2022 at 11:42, Jiang Jian <[email protected]> wrote:
>
> there is an unexpected word "the" in the comments that need to be removed
>
> * command hasn't already completed (indicating the the irq

I am fine with picking up patches for these kinds of trivial
spelling/wording mistakes. However, in this case, it seems silly to
have one patch per single line of change. Would you mind walking
through the entire drivers/mmc/host/* directory and make one patch for
all the mmc host drivers instead?

Then if you want to continue with the mmc core files, that could be
another separate patch.

Kind regards
Uffe

>
> Signed-off-by: Jiang Jian <[email protected]>
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 581614196a84..7f00d7d7e35e 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1363,7 +1363,7 @@ static void __dw_mci_start_request(struct dw_mci *host,
> * is just about to roll over.
> *
> * We do this whole thing under spinlock and only if the
> - * command hasn't already completed (indicating the the irq
> + * command hasn't already completed (indicating the irq
> * already ran so we don't want the timeout).
> */
> spin_lock_irqsave(&host->irq_lock, irqflags);
> --
> 2.17.1
>
>