2022-05-16 17:26:09

by 谭 永林

Subject: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

The product's enumeration align with previous
Quectel EM120R-GL, so the EM120 FCCL would use
the same config as Quectel EM120R-GL.

Signed-off-by: Yonglin Tan <[email protected]>
---

V2:
Fixed the format errors in the patch description.

drivers/bus/mhi/host/pci_generic.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 8416267..0a6469c 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+ { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
+ .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
--
2.7.4

2022-05-23 07:32:25

by 谭 永林

Subject: 回复: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

Hi Mani,

Do you have any concern about this patch?

-----?ʼ?ԭ??-----
??????: Yonglin Tan <[email protected]>
????ʱ??: 2022??5??16?? 14:38
?ռ???: [email protected]; [email protected]; [email protected]; [email protected]
????: [email protected]; [email protected]; [email protected]; Yonglin Tan <[email protected]>
????: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

The product's enumeration align with previous
Quectel EM120R-GL, so the EM120 FCCL would use
the same config as Quectel EM120R-GL.

Signed-off-by: Yonglin Tan <[email protected]>
---

V2:
Fixed the format errors in the patch description.

drivers/bus/mhi/host/pci_generic.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 8416267..0a6469c 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
{ PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+ { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
+ .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
{ PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
.driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
--
2.7.4

2022-05-24 18:15:29

by Loic Poulain

Subject: Re: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

On Mon, 16 May 2022 at 08:38, Yonglin Tan <[email protected]> wrote:
>
> The product's enumeration align with previous
> Quectel EM120R-GL, so the EM120 FCCL would use
> the same config as Quectel EM120R-GL.
>
> Signed-off-by: Yonglin Tan <[email protected]>

Reviewed-by: Loic Poulain <[email protected]>

> ---
>
> V2:
> Fixed the format errors in the patch description.
>
> drivers/bus/mhi/host/pci_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
> .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
>

2022-05-25 03:10:10

by Manivannan Sadhasivam

Subject: Re: 回复: [PATC H v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

On Mon, May 23, 2022 at 02:14:15AM +0000, 谭 永林 wrote:
> Hi Mani,
>
> Do you have any concern about this patch?

Merge window for 5.19 is open now. I'll start picking up patches once it
closes (approx. 2 weeks).

Thanks for the patience!

Thanks,
Mani

>
> -----邮件原件-----
> 发件人: Yonglin Tan <[email protected]>
> 发送时间: 2022年5月16日 14:38
> 收件人: [email protected]; [email protected]; [email protected]; [email protected]
> 抄送: [email protected]; [email protected]; [email protected]; Yonglin Tan <[email protected]>
> 主题: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.
>
> The product's enumeration align with previous
> Quectel EM120R-GL, so the EM120 FCCL would use
> the same config as Quectel EM120R-GL.
>
> Signed-off-by: Yonglin Tan <[email protected]>
> ---
>
> V2:
> Fixed the format errors in the patch description.
>
> drivers/bus/mhi/host/pci_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
> .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
>

--
மணிவண்ணன் சதாசிவம்

2022-06-16 09:05:10

by 谭 永林

Subject: 回复: 回复: [PATCH v2] bus: mhi: host: Ad d support for Quectel EM120 FCCL.

Dear Mani,

Sorry to bother you again, any progress for this patch?
Do you need me to resend the patch to you?

-----邮件原件-----
发件人: [email protected] <[email protected]>
发送时间: 2022年5月24日 21:44
收件人: 谭 永林 <[email protected]>
抄送: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
主题: Re: 回复: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

On Mon, May 23, 2022 at 02:14:15AM +0000, 谭 永林 wrote:
> Hi Mani,
>
> Do you have any concern about this patch?

Merge window for 5.19 is open now. I'll start picking up patches once it closes (approx. 2 weeks).

Thanks for the patience!

Thanks,
Mani

>
> -----邮件原件-----
> 发件人: Yonglin Tan <[email protected]>
> 发送时间: 2022年5月16日 14:38
> 收件人: [email protected]; [email protected];
> [email protected]; [email protected]
> 抄送: [email protected]; [email protected];
> [email protected]; Yonglin Tan <[email protected]>
> 主题: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.
>
> The product's enumeration align with previous Quectel EM120R-GL, so
> the EM120 FCCL would use the same config as Quectel EM120R-GL.
>
> Signed-off-by: Yonglin Tan <[email protected]>
> ---
>
> V2:
> Fixed the format errors in the patch description.
>
> drivers/bus/mhi/host/pci_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
> .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
>

--
மணிவண்ணன் சதாசிவம்

2022-06-21 13:14:29

by Manivannan Sadhasivam

Subject: Re: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

On Mon, May 16, 2022 at 02:38:29PM +0800, Yonglin Tan wrote:
> The product's enumeration align with previous
> Quectel EM120R-GL, so the EM120 FCCL would use
> the same config as Quectel EM120R-GL.
>
> Signed-off-by: Yonglin Tan <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani

> ---
>
> V2:
> Fixed the format errors in the patch description.
>
> drivers/bus/mhi/host/pci_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
> .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
>

--
மணிவண்ணன் சதாசிவம்

2022-06-21 13:16:03

by Manivannan Sadhasivam

Subject: Re: [PATCH v2] bus: mhi: host: Add support for Quectel EM120 FCCL.

On Mon, May 16, 2022 at 02:38:29PM +0800, Yonglin Tan wrote:
> The product's enumeration align with previous
> Quectel EM120R-GL, so the EM120 FCCL would use
> the same config as Quectel EM120R-GL.
>
> Signed-off-by: Yonglin Tan <[email protected]>

Applied to mhi-next!

Thanks,
Mani

> ---
>
> V2:
> Fixed the format errors in the patch description.
>
> drivers/bus/mhi/host/pci_generic.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 8416267..0a6469c 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -557,6 +557,8 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(0x1eac, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + { PCI_DEVICE(0x1eac, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> { PCI_DEVICE(PCI_VENDOR_ID_FOXCONN, 0xe0ab),
> .driver_data = (kernel_ulong_t) &mhi_foxconn_sdx55_info },
> --
> 2.7.4
>

--
மணிவண்ணன் சதாசிவம்