2022-06-21 13:18:11

by Fabrice Gasnier

[permalink] [raw]
Subject: [PATCH 1/3] usb: host: ohci-platform: add TPL support

From: Amelie Delaunay <[email protected]>

The TPL support is used to identify targeted devices during EH compliance
test. The user can add "tpl-support" in the device tree to enable it.

Signed-off-by: Amelie Delaunay <[email protected]>
Signed-off-by: Fabrice Gasnier <[email protected]>
---
drivers/usb/host/ohci-platform.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 47dfbfe9e5190..0adae62651276 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -28,6 +28,7 @@
#include <linux/usb/ohci_pdriver.h>
#include <linux/usb.h>
#include <linux/usb/hcd.h>
+#include <linux/usb/of.h>

#include "ohci.h"

@@ -210,6 +211,8 @@ static int ohci_platform_probe(struct platform_device *dev)
hcd->rsrc_start = res_mem->start;
hcd->rsrc_len = resource_size(res_mem);

+ hcd->tpl_support = of_usb_host_tpl_support(dev->dev.of_node);
+
err = usb_add_hcd(hcd, irq, IRQF_SHARED);
if (err)
goto err_power;
--
2.25.1


2022-06-21 14:40:00

by Alan Stern

[permalink] [raw]
Subject: Re: [PATCH 1/3] usb: host: ohci-platform: add TPL support

On Tue, Jun 21, 2022 at 03:05:04PM +0200, Fabrice Gasnier wrote:
> From: Amelie Delaunay <[email protected]>
>
> The TPL support is used to identify targeted devices during EH compliance
> test. The user can add "tpl-support" in the device tree to enable it.
>
> Signed-off-by: Amelie Delaunay <[email protected]>
> Signed-off-by: Fabrice Gasnier <[email protected]>
> ---

For this patch and the 2/3 ehci-platform patch:

Acked-by: Alan Stern <[email protected]>

> drivers/usb/host/ohci-platform.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
> index 47dfbfe9e5190..0adae62651276 100644
> --- a/drivers/usb/host/ohci-platform.c
> +++ b/drivers/usb/host/ohci-platform.c
> @@ -28,6 +28,7 @@
> #include <linux/usb/ohci_pdriver.h>
> #include <linux/usb.h>
> #include <linux/usb/hcd.h>
> +#include <linux/usb/of.h>
>
> #include "ohci.h"
>
> @@ -210,6 +211,8 @@ static int ohci_platform_probe(struct platform_device *dev)
> hcd->rsrc_start = res_mem->start;
> hcd->rsrc_len = resource_size(res_mem);
>
> + hcd->tpl_support = of_usb_host_tpl_support(dev->dev.of_node);
> +
> err = usb_add_hcd(hcd, irq, IRQF_SHARED);
> if (err)
> goto err_power;
> --
> 2.25.1
>

2022-06-21 15:09:55

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 1/3] usb: host: ohci-platform: add TPL support

On Tue, Jun 21, 2022 at 03:05:04PM +0200, Fabrice Gasnier wrote:
> From: Amelie Delaunay <[email protected]>
>
> The TPL support is used to identify targeted devices during EH compliance
> test. The user can add "tpl-support" in the device tree to enable it.

What is "TPL" support? What is "EH"?

Please spell things out.

thanks,

greg k-h