2022-06-21 15:53:15

by Jiang Jian

Subject: [PATCH] of: device - Remove duplicate 'of' in two places.

file: ./drivers/of/device.c
line: 22
* @matches: array of of device match structures to search in
changed to
* @matches: array of device match structures to search in

Signed-off-by: Jiang Jian <[email protected]>
---
drivers/of/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/device.c b/drivers/of/device.c
index 874f031442dc..1582388156a9 100644
--- a/drivers/of/device.c
+++ b/drivers/of/device.c
@@ -19,7 +19,7 @@

/**
* of_match_device - Tell if a struct device matches an of_device_id list
- * @matches: array of of device match structures to search in
+ * @matches: array of device match structures to search in
* @dev: the of device structure to match against
*
* Used by a driver to check whether an platform_device present in the
--
2.17.1

2022-06-27 17:47:35

by Rob Herring (Arm)

Subject: Re: [PATCH] of: device - Remove duplicate 'of' in two places.

On Tue, Jun 21, 2022 at 11:42:22PM +0800, Jiang Jian wrote:
> file: ./drivers/of/device.c
> line: 22
> * @matches: array of of device match structures to search in
> changed to
> * @matches: array of device match structures to search in
>
> Signed-off-by: Jiang Jian <[email protected]>
> ---
> drivers/of/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/device.c b/drivers/of/device.c
> index 874f031442dc..1582388156a9 100644
> --- a/drivers/of/device.c
> +++ b/drivers/of/device.c
> @@ -19,7 +19,7 @@
>
> /**
> * of_match_device - Tell if a struct device matches an of_device_id list
> - * @matches: array of of device match structures to search in
> + * @matches: array of device match structures to search in

Maybe that was supposed to be 'of OF device match'?

But really, something like 'NULL terminated array of struct of_device_id
entries to search' would be better.

> * @dev: the of device structure to match against

Like 'of' here.

> *
> * Used by a driver to check whether an platform_device present in the
> --
> 2.17.1
>
>