2022-06-21 16:36:56

by Sricharan Ramabadhran

Subject: [PATCH V2 6/8] dt-bindings: qcom: Add ipq5018 bindings

From: Varadarajan Narayanan <[email protected]>

Document the new ipq5018 SOC/board device tree bindings.

Co-developed-by: Sricharan R <[email protected]>
Signed-off-by: Sricharan R <[email protected]>
Signed-off-by: Varadarajan Narayanan <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 129cdd246223..6665db9c9b28 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -29,6 +29,7 @@ description: |
apq8074
apq8084
apq8096
+ ipq5018
ipq6018
ipq8074
mdm9615
@@ -64,6 +65,7 @@ description: |
hk10-c2
idp
liquid
+ mp03
mtp
qrd
sbc
@@ -198,6 +200,11 @@ properties:
- qcom,ipq4019-dk04.1-c1
- const: qcom,ipq4019

+ - items:
+ - enum:
+ - qcom,ipq5018-mp03
+ - const: qcom,ipq5018
+
- items:
- enum:
- qcom,ipq8064-ap148
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

2022-06-22 15:53:28

by Krzysztof Kozlowski

Subject: Re: [PATCH V2 6/8] dt-bindings: qcom: Add ipq5018 bindings

On 21/06/2022 18:11, Sricharan R wrote:
> From: Varadarajan Narayanan <[email protected]>
>
> Document the new ipq5018 SOC/board device tree bindings.
>
> Co-developed-by: Sricharan R <[email protected]>
> Signed-off-by: Sricharan R <[email protected]>
> Signed-off-by: Varadarajan Narayanan <[email protected]>

Your chain is wrong. Since you send it, your SoB is the last. We have
nice example for this:

https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L473


Best regards,
Krzysztof

2022-06-23 06:43:22

by Sricharan Ramabadhran

Subject: Re: [PATCH V2 6/8] dt-bindings: qcom: Add ipq5018 bindings

On 6/22/2022 8:44 PM, Krzysztof Kozlowski wrote:
> On 21/06/2022 18:11, Sricharan R wrote:
>> From: Varadarajan Narayanan <[email protected]>
>>
>> Document the new ipq5018 SOC/board device tree bindings.
>>
>> Co-developed-by: Sricharan R <[email protected]>
>> Signed-off-by: Sricharan R <[email protected]>
>> Signed-off-by: Varadarajan Narayanan <[email protected]>
> Your chain is wrong. Since you send it, your SoB is the last. We have
> nice example for this:
>
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L473
>
  sure, will fix it.

Regards,
  Sricharan