2022-06-22 09:48:24

by Cédric Le Goater

Subject: [PATCH v2 1/2] spi: aspeed: Add pr_debug in aspeed_spi_dirmap_create()

It helps to analyze the default setting of the control register.

Signed-off-by: Cédric Le Goater <[email protected]>
---
drivers/spi/spi-aspeed-smc.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
index 496f3e1e9079..ac64be289e59 100644
--- a/drivers/spi/spi-aspeed-smc.c
+++ b/drivers/spi/spi-aspeed-smc.c
@@ -558,6 +558,14 @@ static int aspeed_spi_dirmap_create(struct spi_mem_dirmap_desc *desc)
u32 ctl_val;
int ret = 0;

+ dev_dbg(aspi->dev,
+ "CE%d %s dirmap [ 0x%.8llx - 0x%.8llx ] OP %#x mode:%d.%d.%d.%d naddr:%#x ndummies:%#x\n",
+ chip->cs, op->data.dir == SPI_MEM_DATA_IN ? "read" : "write",
+ desc->info.offset, desc->info.offset + desc->info.length,
+ op->cmd.opcode, op->cmd.buswidth, op->addr.buswidth,
+ op->dummy.buswidth, op->data.buswidth,
+ op->addr.nbytes, op->dummy.nbytes);
+
chip->clk_freq = desc->mem->spi->max_speed_hz;

/* Only for reads */
--
2.35.3

2022-06-22 10:49:41

by Andy Shevchenko

Subject: Re: [PATCH v2 1/2] spi: aspeed: Add pr_debug in aspeed_spi_dirmap_create()

On Wed, Jun 22, 2022 at 11:46 AM Cédric Le Goater <[email protected]> wrote:
>
> It helps to analyze the default setting of the control register.

Replace "It" with a slightly more descriptive "what is it?".

Also make the subject aligned with the contents of the patch.

--
With Best Regards,
Andy Shevchenko

2022-06-22 11:02:40

by Paul Menzel

Subject: Re: [PATCH v2 1/2] spi: aspeed: Add pr_debug in aspeed_spi_dirmap_create()

Dear Cédric,


Am 22.06.22 um 11:42 schrieb Cédric Le Goater:
> It helps to analyze the default setting of the control register.

Maybe paste the new log line to the commit message.

> Signed-off-by: Cédric Le Goater <[email protected]>
> ---
> drivers/spi/spi-aspeed-smc.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
> index 496f3e1e9079..ac64be289e59 100644
> --- a/drivers/spi/spi-aspeed-smc.c
> +++ b/drivers/spi/spi-aspeed-smc.c
> @@ -558,6 +558,14 @@ static int aspeed_spi_dirmap_create(struct spi_mem_dirmap_desc *desc)
> u32 ctl_val;
> int ret = 0;
>
> + dev_dbg(aspi->dev,

The commit message summary says `pr_debug()`.

> + "CE%d %s dirmap [ 0x%.8llx - 0x%.8llx ] OP %#x mode:%d.%d.%d.%d naddr:%#x ndummies:%#x\n",
> + chip->cs, op->data.dir == SPI_MEM_DATA_IN ? "read" : "write",
> + desc->info.offset, desc->info.offset + desc->info.length,
> + op->cmd.opcode, op->cmd.buswidth, op->addr.buswidth,
> + op->dummy.buswidth, op->data.buswidth,
> + op->addr.nbytes, op->dummy.nbytes);
> +
> chip->clk_freq = desc->mem->spi->max_speed_hz;
>
> /* Only for reads */

Reviewed-by: Paul Menzel <[email protected]>


Kind regards,

Paul