Hi all,
After merging the battery tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/power/reset/pwr-mlxbf.c: In function 'pwr_mlxbf_probe':
drivers/power/reset/pwr-mlxbf.c:67:15: error: implicit declaration of function 'devm_work_autocancel' [-Werror=implicit-function-declaration]
67 | err = devm_work_autocancel(dev, &priv->send_work, pwr_mlxbf_send_work);
| ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Caused by commit
a4c0094fcf76 ("power: reset: pwr-mlxbf: add BlueField SoC power control driver")
I have used the battery tree from next-20220617 for today.
--
Cheers,
Stephen Rothwell
I will send a patch right away. Need to include #include <linux/devm-helpers.h>
-----Original Message-----
From: Stephen Rothwell <[email protected]>
Sent: Sunday, June 19, 2022 8:45 PM
To: Sebastian Reichel <[email protected]>
Cc: Asmaa Mnebhi <[email protected]>; Linux Kernel Mailing List <[email protected]>; Linux Next Mailing List <[email protected]>
Subject: linux-next: build failure after merge of the battery tree
Hi all,
After merging the battery tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/power/reset/pwr-mlxbf.c: In function 'pwr_mlxbf_probe':
drivers/power/reset/pwr-mlxbf.c:67:15: error: implicit declaration of function 'devm_work_autocancel' [-Werror=implicit-function-declaration]
67 | err = devm_work_autocancel(dev, &priv->send_work, pwr_mlxbf_send_work);
| ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Caused by commit
a4c0094fcf76 ("power: reset: pwr-mlxbf: add BlueField SoC power control driver")
I have used the battery tree from next-20220617 for today.
--
Cheers,
Stephen Rothwell
Hi all,
On Mon, 20 Jun 2022 10:45:03 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/power/reset/pwr-mlxbf.c: In function 'pwr_mlxbf_probe':
> drivers/power/reset/pwr-mlxbf.c:67:15: error: implicit declaration of function 'devm_work_autocancel' [-Werror=implicit-function-declaration]
> 67 | err = devm_work_autocancel(dev, &priv->send_work, pwr_mlxbf_send_work);
> | ^~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> a4c0094fcf76 ("power: reset: pwr-mlxbf: add BlueField SoC power control driver")
>
> I have used the battery tree from next-20220617 for today.
I am still seeing this failure.
--
Cheers,
Stephen Rothwell
I sent a patch on Tuesday and added you as a reviewer. Could you please take a look?
The name of the email/patch: "[PATCH v1 1/1] linux-next: Fix build failure in pwr-mlxbf.c"
Thanks.
Asmaa
-----Original Message-----
From: Stephen Rothwell <[email protected]>
Sent: Thursday, June 23, 2022 10:48 PM
To: Sebastian Reichel <[email protected]>
Cc: Asmaa Mnebhi <[email protected]>; Linux Kernel Mailing List <[email protected]>; Linux Next Mailing List <[email protected]>
Subject: Re: linux-next: build failure after merge of the battery tree
Hi all,
On Mon, 20 Jun 2022 10:45:03 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/power/reset/pwr-mlxbf.c: In function 'pwr_mlxbf_probe':
> drivers/power/reset/pwr-mlxbf.c:67:15: error: implicit declaration of function 'devm_work_autocancel' [-Werror=implicit-function-declaration]
> 67 | err = devm_work_autocancel(dev, &priv->send_work, pwr_mlxbf_send_work);
> | ^~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> a4c0094fcf76 ("power: reset: pwr-mlxbf: add BlueField SoC power control driver")
>
> I have used the battery tree from next-20220617 for today.
I am still seeing this failure.
--
Cheers,
Stephen Rothwell
Hi all,
On Fri, 24 Jun 2022 12:47:30 +1000 Stephen Rothwell <[email protected]> wrote:
>
> On Mon, 20 Jun 2022 10:45:03 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the battery tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/power/reset/pwr-mlxbf.c: In function 'pwr_mlxbf_probe':
> > drivers/power/reset/pwr-mlxbf.c:67:15: error: implicit declaration of function 'devm_work_autocancel' [-Werror=implicit-function-declaration]
> > 67 | err = devm_work_autocancel(dev, &priv->send_work, pwr_mlxbf_send_work);
> > | ^~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> > a4c0094fcf76 ("power: reset: pwr-mlxbf: add BlueField SoC power control driver")
> >
> > I have used the battery tree from next-20220617 for today.
>
> I am still seeing this failure.
I am still getting this failure.
--
Cheers,
Stephen Rothwell
On Mon, 21 Aug 2023, Stephen Rothwell wrote:
> Hi all,
>
> After merging the battery tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/power/supply/rt5033_charger.c: In function 'rt5033_charger_probe':
> drivers/power/supply/rt5033_charger.c:694:19: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration]
Is this because your merge-conflict patch:
linux-next: manual merge of the battery tree with the mfd tree
... removed of_device.h?
> 694 | np_conn = of_parse_phandle(pdev->dev.of_node, "richtek,usb-connector", 0);
> | ^~~~~~~~~~~~~~~~
> drivers/power/supply/rt5033_charger.c:694:17: error: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> 694 | np_conn = of_parse_phandle(pdev->dev.of_node, "richtek,usb-connector", 0);
> | ^
> drivers/power/supply/rt5033_charger.c:695:19: error: implicit declaration of function 'of_get_parent'; did you mean 'kernfs_get_parent'? [-Werror=implicit-function-declaration]
> 695 | np_edev = of_get_parent(np_conn);
> | ^~~~~~~~~~~~~
> | kernfs_get_parent
> drivers/power/supply/rt5033_charger.c:695:17: error: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> 695 | np_edev = of_get_parent(np_conn);
> | ^
>
> Caused by commit
>
> 2ce8284c3115 ("power: Explicitly include correct DT includes")
>
> interacting with commit
>
> 12cc585f36b8 ("power: supply: rt5033_charger: Add cable detection and USB OTG supply")
>
> from the mfd tree.
>
> I have applied the following merge fix patch.
>
> From: Stephen Rothwell <[email protected]>
> Date: Mon, 21 Aug 2023 12:50:12 +1000
> Subject: [PATCH] fixup for "power: Explicitly include correct DT includes"
>
> interacting with commit
>
> 12cc585f36b8 ("power: supply: rt5033_charger: Add cable detection and USB OTG supply")
>
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/power/supply/rt5033_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/rt5033_charger.c b/drivers/power/supply/rt5033_charger.c
> index 4d1198d752b7..4ea769775fa5 100644
> --- a/drivers/power/supply/rt5033_charger.c
> +++ b/drivers/power/supply/rt5033_charger.c
> @@ -11,6 +11,7 @@
> #include <linux/extcon.h>
> #include <linux/module.h>
> #include <linux/mutex.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/power_supply.h>
> #include <linux/regmap.h>
> --
> 2.40.1
>
> --
> Cheers,
> Stephen Rothwell
--
Lee Jones [李琼斯]
On Mon, 21 Aug 2023, Lee Jones wrote:
> On Mon, 21 Aug 2023, Stephen Rothwell wrote:
>
> > Hi all,
> >
> > After merging the battery tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/power/supply/rt5033_charger.c: In function 'rt5033_charger_probe':
> > drivers/power/supply/rt5033_charger.c:694:19: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration]
>
> Is this because your merge-conflict patch:
>
> linux-next: manual merge of the battery tree with the mfd tree
>
> ... removed of_device.h?
Oh, that was Rob's patch. I see now, thanks.
> > 694 | np_conn = of_parse_phandle(pdev->dev.of_node, "richtek,usb-connector", 0);
> > | ^~~~~~~~~~~~~~~~
> > drivers/power/supply/rt5033_charger.c:694:17: error: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> > 694 | np_conn = of_parse_phandle(pdev->dev.of_node, "richtek,usb-connector", 0);
> > | ^
> > drivers/power/supply/rt5033_charger.c:695:19: error: implicit declaration of function 'of_get_parent'; did you mean 'kernfs_get_parent'? [-Werror=implicit-function-declaration]
> > 695 | np_edev = of_get_parent(np_conn);
> > | ^~~~~~~~~~~~~
> > | kernfs_get_parent
> > drivers/power/supply/rt5033_charger.c:695:17: error: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> > 695 | np_edev = of_get_parent(np_conn);
> > | ^
> >
> > Caused by commit
> >
> > 2ce8284c3115 ("power: Explicitly include correct DT includes")
> >
> > interacting with commit
> >
> > 12cc585f36b8 ("power: supply: rt5033_charger: Add cable detection and USB OTG supply")
> >
> > from the mfd tree.
> >
> > I have applied the following merge fix patch.
> >
> > From: Stephen Rothwell <[email protected]>
> > Date: Mon, 21 Aug 2023 12:50:12 +1000
> > Subject: [PATCH] fixup for "power: Explicitly include correct DT includes"
> >
> > interacting with commit
> >
> > 12cc585f36b8 ("power: supply: rt5033_charger: Add cable detection and USB OTG supply")
> >
> > Signed-off-by: Stephen Rothwell <[email protected]>
> > ---
> > drivers/power/supply/rt5033_charger.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/power/supply/rt5033_charger.c b/drivers/power/supply/rt5033_charger.c
> > index 4d1198d752b7..4ea769775fa5 100644
> > --- a/drivers/power/supply/rt5033_charger.c
> > +++ b/drivers/power/supply/rt5033_charger.c
> > @@ -11,6 +11,7 @@
> > #include <linux/extcon.h>
> > #include <linux/module.h>
> > #include <linux/mutex.h>
> > +#include <linux/of.h>
> > #include <linux/platform_device.h>
> > #include <linux/power_supply.h>
> > #include <linux/regmap.h>
> > --
> > 2.40.1
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
>
> --
> Lee Jones [李琼斯]
--
Lee Jones [李琼斯]