There is no particular need to restrict building of S3C I2S driver to
supported platforms within the C unit, because Kconfig does it.
Removing such restricting #ifdef from s3c-i2s-v2 allows compile testing
it on other platforms.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
sound/soc/samsung/s3c-i2s-v2.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c
index 1bec72246ed0..2b221cb0ed03 100644
--- a/sound/soc/samsung/s3c-i2s-v2.c
+++ b/sound/soc/samsung/s3c-i2s-v2.c
@@ -21,17 +21,6 @@
#include "regs-i2s-v2.h"
#include "s3c-i2s-v2.h"
-#undef S3C_IIS_V2_SUPPORTED
-
-#if defined(CONFIG_CPU_S3C2412) \
- || defined(CONFIG_ARCH_S3C64XX) || defined(CONFIG_CPU_S5PV210)
-#define S3C_IIS_V2_SUPPORTED
-#endif
-
-#ifndef S3C_IIS_V2_SUPPORTED
-#error Unsupported CPU model
-#endif
-
#define S3C2412_I2S_DEBUG_CON 0
static inline struct s3c_i2sv2_info *to_info(struct snd_soc_dai *cpu_dai)
--
2.34.1
The module does not use anything from gpio.h header.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
sound/soc/samsung/s3c24xx-i2s.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c
index c1a314b86b15..44e93dc16fc3 100644
--- a/sound/soc/samsung/s3c24xx-i2s.c
+++ b/sound/soc/samsung/s3c24xx-i2s.c
@@ -12,7 +12,6 @@
#include <linux/delay.h>
#include <linux/clk.h>
#include <linux/io.h>
-#include <linux/gpio.h>
#include <linux/module.h>
#include <sound/soc.h>
--
2.34.1
On Mon, 27 Jun 2022 16:34:10 +0200, Krzysztof Kozlowski wrote:
> There is no particular need to restrict building of S3C I2S driver to
> supported platforms within the C unit, because Kconfig does it.
> Removing such restricting #ifdef from s3c-i2s-v2 allows compile testing
> it on other platforms.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/3] ASoC: samsung: s3c-i2s-v2: Allow build for unsupported hardware
commit: 17a1ffc7bc4d5b4657d0f3fe5c01778d8fcab9a3
[2/3] ASoC: samsung: s3c24xx-i2s: Drop unneeded gpio.h include
commit: 3e4bac7cf06e46225322f264e7387efe6ddd457e
[3/3] ASoC: samsung: Enable compile test
commit: f43ff8038e8289ca811b5b89e8cc15083dafe5c4
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark