2022-06-27 17:40:24

by Nícolas F. R. A. Prado

Subject: [PATCH] dt-bindings: pinctrl: mt8192: Add RSEL values to bias-pull-{up,down}

Commit fe44e4984018 ("pinctrl: mediatek: add rsel setting on mt8192")
added RSEL bias type definition for some pins on mt8192. In order to be
able to configure the bias on those pins, add the RSEL values in the
bias-pull-up and bias-pull-down properties in the binding.

Signed-off-by: Nícolas F. R. A. Prado <[email protected]>

---

.../devicetree/bindings/pinctrl/pinctrl-mt8192.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml
index e39f5893bf16..e0e943e5b874 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml
@@ -90,6 +90,9 @@ patternProperties:
- enum: [100, 101, 102, 103]
description: PUPD/R1/R0 pull down type. See MTK_PUPD_SET_R1R0_
defines in dt-bindings/pinctrl/mt65xx.h.
+ - enum: [200, 201, 202, 203]
+ description: RSEL pull down type. See MTK_PULL_SET_RSEL_
+ defines in dt-bindings/pinctrl/mt65xx.h.

bias-pull-up:
oneOf:
@@ -98,6 +101,9 @@ patternProperties:
- enum: [100, 101, 102, 103]
description: PUPD/R1/R0 pull up type. See MTK_PUPD_SET_R1R0_
defines in dt-bindings/pinctrl/mt65xx.h.
+ - enum: [200, 201, 202, 203]
+ description: RSEL pull up type. See MTK_PULL_SET_RSEL_
+ defines in dt-bindings/pinctrl/mt65xx.h.

bias-disable: true

--
2.36.1

2022-06-28 14:21:44

by Linus Walleij

Subject: Re: [PATCH] dt-bindings: pinctrl: mt8192: Add RSEL values to bias-pull-{up,down}

On Mon, Jun 27, 2022 at 7:32 PM Nícolas F. R. A. Prado
<[email protected]> wrote:

> Commit fe44e4984018 ("pinctrl: mediatek: add rsel setting on mt8192")
> added RSEL bias type definition for some pins on mt8192. In order to be
> able to configure the bias on those pins, add the RSEL values in the
> bias-pull-up and bias-pull-down properties in the binding.
>
> Signed-off-by: Nícolas F. R. A. Prado <[email protected]>

Patch applied as uncontroversial and you obviously need this.

Yours,
Linus Walleij