2022-06-28 12:47:15

by Xu Qiang

Subject: [PATCH v2 -next] vdpa/mlx5: Use eth_zero_addr() to assign zero address

Using eth_zero_addr() to assign zero address instead of memset().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Xu Qiang <[email protected]>
---
v2:
- fix typo in commit log
drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index e85c1d71f4ed..f738c78ef446 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1457,8 +1457,8 @@ static int mlx5_vdpa_add_mac_vlan_rules(struct mlx5_vdpa_net *ndev, u8 *mac,

*ucast = rule;

- memset(dmac_c, 0, ETH_ALEN);
- memset(dmac_v, 0, ETH_ALEN);
+ eth_zero_addr(dmac_c);
+ eth_zero_addr(dmac_v);
dmac_c[0] = 1;
dmac_v[0] = 1;
rule = mlx5_add_flow_rules(ndev->rxft, spec, &flow_act, &dest, 1);
--
2.17.1

2022-06-28 20:59:37

by Michael S. Tsirkin

Subject: Re: [PATCH v2 -next] vdpa/mlx5: Use eth_zero_addr() to assign zero address

On Tue, Jun 28, 2022 at 12:34:57PM +0000, Xu Qiang wrote:
> Using eth_zero_addr() to assign zero address instead of memset().
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Xu Qiang <[email protected]>

Acked-by: Michael S. Tsirkin <[email protected]>

> ---
> v2:
> - fix typo in commit log
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index e85c1d71f4ed..f738c78ef446 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1457,8 +1457,8 @@ static int mlx5_vdpa_add_mac_vlan_rules(struct mlx5_vdpa_net *ndev, u8 *mac,
>
> *ucast = rule;
>
> - memset(dmac_c, 0, ETH_ALEN);
> - memset(dmac_v, 0, ETH_ALEN);
> + eth_zero_addr(dmac_c);
> + eth_zero_addr(dmac_v);
> dmac_c[0] = 1;
> dmac_v[0] = 1;
> rule = mlx5_add_flow_rules(ndev->rxft, spec, &flow_act, &dest, 1);
> --
> 2.17.1