2022-06-29 06:06:30

by Vidya Sagar

Subject: [PATCH V3 05/11] arm64: tegra: Add regulators required for PCIe

Add regulator supplies required for PCIe functionality. The supplies
include 1.8V, 3.3V and 12V.

Signed-off-by: Vidya Sagar <[email protected]>
---
V3:
* New patch in this series

.../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 24 +++++++++++++++++++
.../boot/dts/nvidia/tegra234-p3737-0000.dtsi | 23 ++++++++++++++++++
2 files changed, 47 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
index 798de9226ba5..d53901ba45f6 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
@@ -6,6 +6,30 @@
model = "NVIDIA Jetson AGX Orin";
compatible = "nvidia,p3701-0000", "nvidia,tegra234";

+ fixed-regulators {
+ compatible = "simple-bus";
+ device_type = "fixed-regulators";
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+
+ p3701_vdd_1v8_ls: regulator@3 {
+ compatible = "regulator-fixed";
+ reg = <3>;
+ regulator-name = "vdd-1v8-ls-sw5";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ p3701_vdd_AO_1v8: regulator@5 {
+ compatible = "regulator-fixed";
+ reg = <5>;
+ regulator-name = "vdd-AO-1v8-sw2";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ };
+
bus@0 {
spi@3270000 {
status = "okay";
diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
index a85993c85e45..bb503643dd38 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
@@ -2,4 +2,27 @@

/ {
compatible = "nvidia,p3737-0000";
+
+ fixed-regulators {
+ p3737_vdd_3v3_pcie: regulator@105 {
+ compatible = "regulator-fixed";
+ reg = <105>;
+ regulator-name = "vdd-3v3-pcie";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ gpio = <&gpio TEGRA234_MAIN_GPIO(Z, 2) 0>;
+ enable-active-high;
+ regulator-boot-on;
+ };
+ p3737_vdd_12v_pcie: regulator@114 {
+ compatible = "regulator-fixed";
+ reg = <114>;
+ regulator-name = "vdd-12v-pcie";
+ regulator-min-microvolt = <12000000>;
+ regulator-max-microvolt = <12000000>;
+ gpio = <&gpio TEGRA234_MAIN_GPIO(A, 1) 1>;
+ regulator-boot-on;
+ enable-active-low;
+ };
+ };
};
--
2.17.1

2022-06-29 06:57:40

by Krzysztof Kozlowski

Subject: Re: [PATCH V3 05/11] arm64: tegra: Add regulators required for PCIe

On 29/06/2022 08:04, Vidya Sagar wrote:
> Add regulator supplies required for PCIe functionality. The supplies
> include 1.8V, 3.3V and 12V.
>
> Signed-off-by: Vidya Sagar <[email protected]>
> ---
> V3:
> * New patch in this series
>
> .../boot/dts/nvidia/tegra234-p3701-0000.dtsi | 24 +++++++++++++++++++
> .../boot/dts/nvidia/tegra234-p3737-0000.dtsi | 23 ++++++++++++++++++
> 2 files changed, 47 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> index 798de9226ba5..d53901ba45f6 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> @@ -6,6 +6,30 @@
> model = "NVIDIA Jetson AGX Orin";
> compatible = "nvidia,p3701-0000", "nvidia,tegra234";
>
> + fixed-regulators {
> + compatible = "simple-bus";
> + device_type = "fixed-regulators";
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;

This is not a bus, fixed regulators are not part of some bus.

> +
> + p3701_vdd_1v8_ls: regulator@3 {
> + compatible = "regulator-fixed";
> + reg = <3>;

This fails schema. No.

> + regulator-name = "vdd-1v8-ls-sw5";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };

Missing blank line.

> + p3701_vdd_AO_1v8: regulator@5 {
> + compatible = "regulator-fixed";
> + reg = <5>;
> + regulator-name = "vdd-AO-1v8-sw2";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> + };
> +
> bus@0 {
> spi@3270000 {
> status = "okay";
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> index a85993c85e45..bb503643dd38 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000.dtsi
> @@ -2,4 +2,27 @@
>
> / {
> compatible = "nvidia,p3737-0000";
> +
> + fixed-regulators {
> + p3737_vdd_3v3_pcie: regulator@105 {
> + compatible = "regulator-fixed";
> + reg = <105>;
> + regulator-name = "vdd-3v3-pcie";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio TEGRA234_MAIN_GPIO(Z, 2) 0>;
> + enable-active-high;
> + regulator-boot-on;
> + };

Same comments.

> + p3737_vdd_12v_pcie: regulator@114 {
> + compatible = "regulator-fixed";
> + reg = <114>;
> + regulator-name = "vdd-12v-pcie";
> + regulator-min-microvolt = <12000000>;
> + regulator-max-microvolt = <12000000>;
> + gpio = <&gpio TEGRA234_MAIN_GPIO(A, 1) 1>;
> + regulator-boot-on;
> + enable-active-low;
> + };
> + };
> };


Best regards,
Krzysztof