2022-06-29 06:41:25

by Hangyu Hua

Subject: [PATCH v2] net: tipc: fix possible refcount leak in tipc_sk_create()

Free sk in case tipc_sk_insert() fails.

Signed-off-by: Hangyu Hua <[email protected]>
---

v2: use a succinct commit log.

net/tipc/socket.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 17f8c523e33b..43509c7e90fc 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -502,6 +502,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock,
sock_init_data(sock, sk);
tipc_set_sk_state(sk, TIPC_OPEN);
if (tipc_sk_insert(tsk)) {
+ sk_free(sk);
pr_warn("Socket create failed; port number exhausted\n");
return -EINVAL;
}
--
2.25.1

2022-06-29 10:40:22

by Tung Quang Nguyen

Subject: RE: [PATCH v2] net: tipc: fix possible refcount leak in tipc_sk_create()

> Subject: [PATCH v2] net: tipc: fix possible refcount leak in tipc_sk_create()
>
> Free sk in case tipc_sk_insert() fails.
>
> Signed-off-by: Hangyu Hua <[email protected]>
> ---
>
> v2: use a succinct commit log.
>
> net/tipc/socket.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index 17f8c523e33b..43509c7e90fc 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -502,6 +502,7 @@ static int tipc_sk_create(struct net *net, struct socket *sock,
> sock_init_data(sock, sk);
> tipc_set_sk_state(sk, TIPC_OPEN);
> if (tipc_sk_insert(tsk)) {
> + sk_free(sk);
> pr_warn("Socket create failed; port number exhausted\n");
> return -EINVAL;
> }
> --
> 2.25.1
Reviewed-by: Tung Nguyen <[email protected]>

2022-06-29 13:25:37

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] net: tipc: fix possible refcount leak in tipc_sk_create()

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:

On Wed, 29 Jun 2022 14:34:18 +0800 you wrote:
> Free sk in case tipc_sk_insert() fails.
>
> Signed-off-by: Hangyu Hua <[email protected]>
> ---
>
> v2: use a succinct commit log.
>
> [...]

Here is the summary with links:
- [v2] net: tipc: fix possible refcount leak in tipc_sk_create()
https://git.kernel.org/netdev/net/c/00aff3590fc0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html