2022-06-29 09:07:32

by Li kunyu

Subject: [PATCH] drivers: Remove extra commas and align them

There is an extra comma and space in this sentence when I read the code.

Signed-off-by: Li kunyu <[email protected]>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
index 4a872f328fea..7d5204834ee2 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c
@@ -85,7 +85,7 @@ static void cxgb4_dcb_cleanup_apps(struct net_device *dev)

if (err) {
dev_err(adap->pdev_dev,
- "Failed DCB Clear %s Application Priority: sel=%d, prot=%d, , err=%d\n",
+ "Failed DCB Clear %s Application Priority: sel=%d, prot=%d, err=%d\n",
dcb_ver_array[dcb->dcb_version], app.selector,
app.protocol, -err);
break;
--
2.18.2

2022-06-30 11:41:02

by Paolo Abeni

Subject: Re: [PATCH] drivers: Remove extra commas and align them

On Wed, 2022-06-29 at 16:35 +0800, Li kunyu wrote:
> There is an extra comma and space in this sentence when I read the code.
>
> Signed-off-by: Li kunyu <[email protected]>

Sorry, I'm going to be quite nitpicking on this kind of patches. Please
try to stick to a consistent format, see Jakub guidance:

https://lore.kernel.org/all/[email protected]/

e.g.

<sub-system>: fix typo in <somewhere>

Remove the repeated <what> from <somewhere>

Thanks!

Paolo