2022-06-29 10:41:19

by Colin Ian King

Subject: [PATCH] ALSA: wavefront: remove redundant assignment to pointer end

Pointer end is being re-assigned the same value as it was initialized
with in the previous statement. The re-assignment is redundant and
can be removed.

Cleans up clang scan-build warning:
sound/isa/wavefront/wavefront_synth.c:582:17: warning: Value stored
to 'end' during its initialization is never read

Signed-off-by: Colin Ian King <[email protected]>
---
sound/isa/wavefront/wavefront_synth.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c
index 2aaaa6807174..13ce96148fa3 100644
--- a/sound/isa/wavefront/wavefront_synth.c
+++ b/sound/isa/wavefront/wavefront_synth.c
@@ -581,8 +581,6 @@ demunge_buf (unsigned char *src, unsigned char *dst, unsigned int src_bytes)
int i;
unsigned char *end = src + src_bytes;

- end = src + src_bytes;
-
/* NOTE: src and dst *CAN* point to the same address */

for (i = 0; src != end; i++) {
--
2.35.3

2022-06-29 11:04:59

by Colin Ian King

Subject: [PATCH] ALSA: wavefront: remove redundant assignment to pointer end

Pointer end is being re-assigned the same value as it was initialized
with in the previous statement. The re-assignment is redundant and
can be removed.

Cleans up clang scan-build warning:
sound/isa/wavefront/wavefront_synth.c:582:17: warning: Value stored
to 'end' during its initialization is never read

Signed-off-by: Colin Ian King <[email protected]>
---
sound/isa/wavefront/wavefront_synth.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c
index 2aaaa6807174..13ce96148fa3 100644
--- a/sound/isa/wavefront/wavefront_synth.c
+++ b/sound/isa/wavefront/wavefront_synth.c
@@ -581,8 +581,6 @@ demunge_buf (unsigned char *src, unsigned char *dst, unsigned int src_bytes)
int i;
unsigned char *end = src + src_bytes;

- end = src + src_bytes;
-
/* NOTE: src and dst *CAN* point to the same address */

for (i = 0; src != end; i++) {
--
2.35.3

2022-07-04 12:32:09

by Takashi Iwai

Subject: Re: [PATCH] ALSA: wavefront: remove redundant assignment to pointer end

On Wed, 29 Jun 2022 12:27:43 +0200,
Colin Ian King wrote:
>
> Pointer end is being re-assigned the same value as it was initialized
> with in the previous statement. The re-assignment is redundant and
> can be removed.
>
> Cleans up clang scan-build warning:
> sound/isa/wavefront/wavefront_synth.c:582:17: warning: Value stored
> to 'end' during its initialization is never read
>
> Signed-off-by: Colin Ian King <[email protected]>

Thanks, applied now.


Takashi