2022-06-29 21:17:53

by Marcus Folkesson

Subject: [PATCH] iio: adc: ti-tsc2046: do not explicity set INDIO_BUFFER_TRIGGERED mode

The core sets INDIO_BUFFER_TRIGGERED as part of
devm_iio_triggered_buffer_setup().

Signed-off-by: Marcus Folkesson <[email protected]>
---
drivers/iio/adc/ti-tsc2046.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
index 55b35570ad8b..0d9436a69cbf 100644
--- a/drivers/iio/adc/ti-tsc2046.c
+++ b/drivers/iio/adc/ti-tsc2046.c
@@ -776,7 +776,7 @@ static int tsc2046_adc_probe(struct spi_device *spi)
priv->spi = spi;

indio_dev->name = TI_TSC2046_NAME;
- indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
+ indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->channels = dcfg->channels;
indio_dev->num_channels = dcfg->num_channels;
indio_dev->info = &tsc2046_adc_info;
--
2.36.1

2022-06-30 05:49:53

by Oleksij Rempel

Subject: Re: [PATCH] iio: adc: ti-tsc2046: do not explicity set INDIO_BUFFER_TRIGGERED mode

On Wed, Jun 29, 2022 at 10:39:10PM +0200, Marcus Folkesson wrote:
> The core sets INDIO_BUFFER_TRIGGERED as part of
> devm_iio_triggered_buffer_setup().
>
> Signed-off-by: Marcus Folkesson <[email protected]>

Reviewed-by: Oleksij Rempel <[email protected]>

Thank you!

> ---
> drivers/iio/adc/ti-tsc2046.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
> index 55b35570ad8b..0d9436a69cbf 100644
> --- a/drivers/iio/adc/ti-tsc2046.c
> +++ b/drivers/iio/adc/ti-tsc2046.c
> @@ -776,7 +776,7 @@ static int tsc2046_adc_probe(struct spi_device *spi)
> priv->spi = spi;
>
> indio_dev->name = TI_TSC2046_NAME;
> - indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
> + indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->channels = dcfg->channels;
> indio_dev->num_channels = dcfg->num_channels;
> indio_dev->info = &tsc2046_adc_info;
> --
> 2.36.1
>
>
>

--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2022-07-01 17:10:26

by Jonathan Cameron

Subject: Re: [PATCH] iio: adc: ti-tsc2046: do not explicity set INDIO_BUFFER_TRIGGERED mode

On Thu, 30 Jun 2022 07:07:26 +0200
Oleksij Rempel <[email protected]> wrote:

> On Wed, Jun 29, 2022 at 10:39:10PM +0200, Marcus Folkesson wrote:
> > The core sets INDIO_BUFFER_TRIGGERED as part of
> > devm_iio_triggered_buffer_setup().
> >
> > Signed-off-by: Marcus Folkesson <[email protected]>
>
> Reviewed-by: Oleksij Rempel <[email protected]>
>
Applied,

Thanks,

Jonathan

> Thank you!
>
> > ---
> > drivers/iio/adc/ti-tsc2046.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ti-tsc2046.c b/drivers/iio/adc/ti-tsc2046.c
> > index 55b35570ad8b..0d9436a69cbf 100644
> > --- a/drivers/iio/adc/ti-tsc2046.c
> > +++ b/drivers/iio/adc/ti-tsc2046.c
> > @@ -776,7 +776,7 @@ static int tsc2046_adc_probe(struct spi_device *spi)
> > priv->spi = spi;
> >
> > indio_dev->name = TI_TSC2046_NAME;
> > - indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
> > + indio_dev->modes = INDIO_DIRECT_MODE;
> > indio_dev->channels = dcfg->channels;
> > indio_dev->num_channels = dcfg->num_channels;
> > indio_dev->info = &tsc2046_adc_info;
> > --
> > 2.36.1
> >
> >
> >
>