2022-06-29 21:32:01

by Rob Herring (Arm)

Subject: [PATCH] Revert "drivers/video/backlight/platform_lcd.c: add support for device tree based probe"

This reverts commit 52e842432f36d5b15227d0ee0d2aa3d2bc3cc0b2.

The DT support never would have worked because there's no platform_data
providing ops. There's not any documented binding for it either.

Cc: Jingoo Han <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
drivers/video/backlight/platform_lcd.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c
index b2bfbf070200..dc37494baf42 100644
--- a/drivers/video/backlight/platform_lcd.c
+++ b/drivers/video/backlight/platform_lcd.c
@@ -12,7 +12,6 @@
#include <linux/fb.h>
#include <linux/backlight.h>
#include <linux/lcd.h>
-#include <linux/of.h>
#include <linux/slab.h>

#include <video/platform_lcd.h>
@@ -133,19 +132,10 @@ static int platform_lcd_resume(struct device *dev)
static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend,
platform_lcd_resume);

-#ifdef CONFIG_OF
-static const struct of_device_id platform_lcd_of_match[] = {
- { .compatible = "platform-lcd" },
- {},
-};
-MODULE_DEVICE_TABLE(of, platform_lcd_of_match);
-#endif
-
static struct platform_driver platform_lcd_driver = {
.driver = {
.name = "platform-lcd",
.pm = &platform_lcd_pm_ops,
- .of_match_table = of_match_ptr(platform_lcd_of_match),
},
.probe = platform_lcd_probe,
};
--
2.34.1

2022-07-06 09:03:35

by Daniel Thompson

Subject: Re: [PATCH] Revert "drivers/video/backlight/platform_lcd.c: add support for device tree based probe"

On Wed, Jun 29, 2022 at 03:00:23PM -0600, Rob Herring wrote:
> This reverts commit 52e842432f36d5b15227d0ee0d2aa3d2bc3cc0b2.
>
> The DT support never would have worked because there's no platform_data
> providing ops. There's not any documented binding for it either.
>
> Cc: Jingoo Han <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.


> ---
> drivers/video/backlight/platform_lcd.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/video/backlight/platform_lcd.c b/drivers/video/backlight/platform_lcd.c
> index b2bfbf070200..dc37494baf42 100644
> --- a/drivers/video/backlight/platform_lcd.c
> +++ b/drivers/video/backlight/platform_lcd.c
> @@ -12,7 +12,6 @@
> #include <linux/fb.h>
> #include <linux/backlight.h>
> #include <linux/lcd.h>
> -#include <linux/of.h>
> #include <linux/slab.h>
>
> #include <video/platform_lcd.h>
> @@ -133,19 +132,10 @@ static int platform_lcd_resume(struct device *dev)
> static SIMPLE_DEV_PM_OPS(platform_lcd_pm_ops, platform_lcd_suspend,
> platform_lcd_resume);
>
> -#ifdef CONFIG_OF
> -static const struct of_device_id platform_lcd_of_match[] = {
> - { .compatible = "platform-lcd" },
> - {},
> -};
> -MODULE_DEVICE_TABLE(of, platform_lcd_of_match);
> -#endif
> -
> static struct platform_driver platform_lcd_driver = {
> .driver = {
> .name = "platform-lcd",
> .pm = &platform_lcd_pm_ops,
> - .of_match_table = of_match_ptr(platform_lcd_of_match),
> },
> .probe = platform_lcd_probe,
> };
> --
> 2.34.1
>

2022-07-13 08:14:56

by Lee Jones

Subject: Re: [PATCH] Revert "drivers/video/backlight/platform_lcd.c: add support for device tree based probe"

On Wed, 29 Jun 2022, Rob Herring wrote:

> This reverts commit 52e842432f36d5b15227d0ee0d2aa3d2bc3cc0b2.
>
> The DT support never would have worked because there's no platform_data
> providing ops. There's not any documented binding for it either.
>
> Cc: Jingoo Han <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> drivers/video/backlight/platform_lcd.c | 10 ----------
> 1 file changed, 10 deletions(-)

Applied, thanks.

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog