2022-06-30 08:38:20

by Zhang Jiaming

[permalink] [raw]
Subject: [PATCH] mm/mmap.c: Fix typo and space mistake

Change 'writeable' to 'writable'.
Delete or add spaces around ','.

Signed-off-by: Zhang Jiaming <[email protected]>
---
mm/mmap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 8f776f257893..e3a7da24e83c 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -1603,7 +1603,7 @@ int vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot)
}

/*
- * We account for memory if it's a private writeable mapping,
+ * We account for memory if it's a private writable mapping,
* not hugepages and VM_NORESERVE wasn't set.
*/
static inline int accountable_mapping(struct file *file, vm_flags_t vm_flags)
@@ -2642,7 +2642,7 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
(vma ? can_vma_merge_after(prev, vm_flags, vma->anon_vma, file,
pgoff, vma->vm_userfaultfd_ctx, NULL) :
can_vma_merge_after(prev, vm_flags, NULL, file, pgoff,
- NULL_VM_UFFD_CTX , NULL))) {
+ NULL_VM_UFFD_CTX, NULL))) {
merge_start = prev->vm_start;
vma = prev;
vm_pgoff = prev->vm_pgoff;
@@ -3146,7 +3146,7 @@ int vm_brk_flags(unsigned long addr, unsigned long request, unsigned long flags)
vma = mas_prev(&mas, 0);
if (!vma || vma->vm_end != addr || vma_policy(vma) ||
!can_vma_merge_after(vma, flags, NULL, NULL,
- addr >> PAGE_SHIFT,NULL_VM_UFFD_CTX, NULL))
+ addr >> PAGE_SHIFT, NULL_VM_UFFD_CTX, NULL))
vma = NULL;

ret = do_brk_flags(&mas, vma, addr, len, flags);
--
2.34.1


2022-07-01 23:09:05

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] mm/mmap.c: Fix typo and space mistake

On Thu, 30 Jun 2022 16:31:24 +0800 Zhang Jiaming <[email protected]> wrote:

> Change 'writeable' to 'writable'.
> Delete or add spaces around ','.
>

"writeable" is actually OK. Less common than "writable".

I do feel the patch is too minor to bother changing the kernel for,
sorry.