2022-06-30 16:58:07

by Clément Léger

[permalink] [raw]
Subject: [PATCH net-next v2] dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description

Describe the switch interrupts (dlr, switch, prp, hub, pattern) which
are connected to the GIC.

Signed-off-by: Clément Léger <[email protected]>
---
Changes in V2:
- Fix typo in interrupt-names property.

.../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 23 +++++++++++++++++++
1 file changed, 23 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
index 103b1ef5af1b..e68c7e353100 100644
--- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
@@ -26,6 +26,22 @@ properties:
reg:
maxItems: 1

+ interrupts:
+ items:
+ - description: DLR interrupt
+ - description: Switch interrupt
+ - description: PRP interrupt
+ - description: Integrated HUB module interrupt
+ - description: RX Pattern interrupt
+
+ interrupt-names:
+ items:
+ - const: dlr
+ - const: switch
+ - const: prp
+ - const: hub
+ - const: ptrn
+
power-domains:
maxItems: 1

@@ -76,6 +92,7 @@ examples:
- |
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/clock/r9a06g032-sysctrl.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>

switch@44050000 {
compatible = "renesas,r9a06g032-a5psw", "renesas,rzn1-a5psw";
@@ -83,6 +100,12 @@ examples:
clocks = <&sysctrl R9A06G032_HCLK_SWITCH>, <&sysctrl R9A06G032_CLK_SWITCH>;
clock-names = "hclk", "clk";
power-domains = <&sysctrl>;
+ interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "dlr", "switch", "prp", "hub", "ptrn";

dsa,member = <0 0>;

--
2.36.1


2022-07-01 00:25:45

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH net-next v2] dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description

On Thu, 30 Jun 2022 18:25:15 +0200, Cl?ment L?ger wrote:
> Describe the switch interrupts (dlr, switch, prp, hub, pattern) which
> are connected to the GIC.
>
> Signed-off-by: Cl?ment L?ger <[email protected]>
> ---
> Changes in V2:
> - Fix typo in interrupt-names property.
>
> .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
>

Reviewed-by: Rob Herring <[email protected]>

2022-07-01 08:29:59

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH net-next v2] dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description

Hi Clément,

On Thu, Jun 30, 2022 at 6:26 PM Clément Léger <[email protected]> wrote:
> Describe the switch interrupts (dlr, switch, prp, hub, pattern) which
> are connected to the GIC.
>
> Signed-off-by: Clément Léger <[email protected]>
> ---
> Changes in V2:
> - Fix typo in interrupt-names property.

Thanks for the update!

Reviewed-by: Geert Uytterhoeven <[email protected]>
but some suggestions below.

> --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> @@ -26,6 +26,22 @@ properties:
> reg:
> maxItems: 1
>
> + interrupts:
> + items:
> + - description: DLR interrupt

Device Level Ring (DLR) interrupt?

> + - description: Switch interrupt
> + - description: PRP interrupt

Parallel Redundancy Protocol (PRP) interrupt?

> + - description: Integrated HUB module interrupt
> + - description: RX Pattern interrupt

Receive Pattern Match interrupt?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2022-07-01 17:57:00

by Clément Léger

[permalink] [raw]
Subject: Re: [PATCH net-next v2] dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description

Le Fri, 1 Jul 2022 09:45:51 +0200,
Geert Uytterhoeven <[email protected]> a écrit :

> Hi Clément,
>
> On Thu, Jun 30, 2022 at 6:26 PM Clément Léger <[email protected]> wrote:
> > Describe the switch interrupts (dlr, switch, prp, hub, pattern) which
> > are connected to the GIC.
> >
> > Signed-off-by: Clément Léger <[email protected]>
> > ---
> > Changes in V2:
> > - Fix typo in interrupt-names property.
>
> Thanks for the update!
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> but some suggestions below.
>
> > --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> > @@ -26,6 +26,22 @@ properties:
> > reg:
> > maxItems: 1
> >
> > + interrupts:
> > + items:
> > + - description: DLR interrupt
>
> Device Level Ring (DLR) interrupt?
>
> > + - description: Switch interrupt
> > + - description: PRP interrupt
>
> Parallel Redundancy Protocol (PRP) interrupt?
>
> > + - description: Integrated HUB module interrupt
> > + - description: RX Pattern interrupt
>
> Receive Pattern Match interrupt?

Hi Geert,

I'll modify that and send a V3, thanks for your comments !

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds



--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com