2022-06-30 18:11:40

by Hsin-Yi Wang

Subject: [PATCH] video: of_display_timing.h: include errno.h

If CONFIG_OF is not enabled, default of_get_display_timing() returns an
errno, so include the header.

Fixes: 422b67e0b31a ("videomode: provide dummy inline functions for !CONFIG_OF")
Suggested-by: Stephen Boyd <[email protected]>
Signed-off-by: Hsin-Yi Wang <[email protected]>
---
include/video/of_display_timing.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/video/of_display_timing.h b/include/video/of_display_timing.h
index e1126a74882a5..eff166fdd81b9 100644
--- a/include/video/of_display_timing.h
+++ b/include/video/of_display_timing.h
@@ -8,6 +8,8 @@
#ifndef __LINUX_OF_DISPLAY_TIMING_H
#define __LINUX_OF_DISPLAY_TIMING_H

+#include <linux/errno.h>
+
struct device_node;
struct display_timing;
struct display_timings;
--
2.37.0.rc0.161.g10f37bed90-goog

2022-06-30 23:35:13

by Stephen Boyd

Subject: Re: [PATCH] video: of_display_timing.h: include errno.h

Quoting Hsin-Yi Wang (2022-06-30 10:33:29)
> If CONFIG_OF is not enabled, default of_get_display_timing() returns an
> errno, so include the header.
>
> Fixes: 422b67e0b31a ("videomode: provide dummy inline functions for !CONFIG_OF")
> Suggested-by: Stephen Boyd <[email protected]>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2022-07-06 15:24:37

by Helge Deller

Subject: Re: [PATCH] video: of_display_timing.h: include errno.h

On 7/1/22 01:27, Stephen Boyd wrote:
> Quoting Hsin-Yi Wang (2022-06-30 10:33:29)
>> If CONFIG_OF is not enabled, default of_get_display_timing() returns an
>> errno, so include the header.
>>
>> Fixes: 422b67e0b31a ("videomode: provide dummy inline functions for !CONFIG_OF")
>> Suggested-by: Stephen Boyd <[email protected]>
>> Signed-off-by: Hsin-Yi Wang <[email protected]>
>> ---
>
> Reviewed-by: Stephen Boyd <[email protected]>

Applied to fbdev git tree.

Thanks!
Helge