2022-07-01 09:16:34

by Dmitry Osipenko

[permalink] [raw]
Subject: [PATCH v8 0/2] DRM GEM fixes

This patchset fixes two problems in the common GEM code. First fixed problem
is the bogus lockdep splat that complicates debugging of DRM drivers. Second
problem is the inconsistency in behaviour and improper handling of mapping
the imported GEMs by some drivers, to fix it we will prohibit to map the
imported GEMs like majority of drivers already do.

Changelog:

v8: - Dropped stable tag from the "Don't map imported GEMs" patch,
like was suggested by Thomas Hellström in the review comment to v7.

v7: - Factored out GEM patches from [1] since I'll be working on the
dma-buf locking in a separate patchset now.

[1] https://lore.kernel.org/all/[email protected]/

- Improved commit message and added fixes tag to the "Properly annotate
WW context" patch.

- Replaced "Move mapping of imported dma-bufs to drm_gem_mmap_obj()"
patch with "Don't map imported GEMs", like was suggested by
Thomas Hellström.

- Added r-b and suggested-by from Thomas Hellström.

Dmitry Osipenko (2):
drm/gem: Properly annotate WW context on drm_gem_lock_reservations()
error
drm/gem: Don't map imported GEMs

drivers/gpu/drm/drm_gem.c | 8 ++++++--
drivers/gpu/drm/drm_gem_shmem_helper.c | 9 ---------
2 files changed, 6 insertions(+), 11 deletions(-)

--
2.36.1


2022-07-22 11:51:13

by Dmitry Osipenko

[permalink] [raw]
Subject: Re: [PATCH v8 0/2] DRM GEM fixes

Hi,

On 7/1/22 12:02, Dmitry Osipenko wrote:
> This patchset fixes two problems in the common GEM code. First fixed problem
> is the bogus lockdep splat that complicates debugging of DRM drivers. Second
> problem is the inconsistency in behaviour and improper handling of mapping
> the imported GEMs by some drivers, to fix it we will prohibit to map the
> imported GEMs like majority of drivers already do.
>
> Changelog:
>
> v8: - Dropped stable tag from the "Don't map imported GEMs" patch,
> like was suggested by Thomas Hellström in the review comment to v7.
>
> v7: - Factored out GEM patches from [1] since I'll be working on the
> dma-buf locking in a separate patchset now.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> - Improved commit message and added fixes tag to the "Properly annotate
> WW context" patch.
>
> - Replaced "Move mapping of imported dma-bufs to drm_gem_mmap_obj()"
> patch with "Don't map imported GEMs", like was suggested by
> Thomas Hellström.
>
> - Added r-b and suggested-by from Thomas Hellström.
>
> Dmitry Osipenko (2):
> drm/gem: Properly annotate WW context on drm_gem_lock_reservations()
> error
> drm/gem: Don't map imported GEMs
>
> drivers/gpu/drm/drm_gem.c | 8 ++++++--
> drivers/gpu/drm/drm_gem_shmem_helper.c | 9 ---------
> 2 files changed, 6 insertions(+), 11 deletions(-)
>

Could anyone please take this into drm-misc-next? Maybe Thomas?

Thanks in advance

--
Best regards,
Dmitry