2022-07-04 02:54:50

by Xu Qiang

Subject: [PATCH -next] vdpa/mlx5: Use eth_broadcast_addr() to assign broadcast address

Using eth_broadcast_addr() to assign broadcast address instead
of memset().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Xu Qiang <[email protected]>
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index f738c78ef446..3b2929d4a819 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1440,7 +1440,7 @@ static int mlx5_vdpa_add_mac_vlan_rules(struct mlx5_vdpa_net *ndev, u8 *mac,
headers_v = MLX5_ADDR_OF(fte_match_param, spec->match_value, outer_headers);
dmac_c = MLX5_ADDR_OF(fte_match_param, headers_c, outer_headers.dmac_47_16);
dmac_v = MLX5_ADDR_OF(fte_match_param, headers_v, outer_headers.dmac_47_16);
- memset(dmac_c, 0xff, ETH_ALEN);
+ eth_broadcast_addr(dmac_c);
ether_addr_copy(dmac_v, mac);
MLX5_SET(fte_match_set_lyr_2_4, headers_c, cvlan_tag, 1);
if (tagged) {
--
2.17.1

2022-07-06 04:24:15

by Jason Wang

Subject: Re: [PATCH -next] vdpa/mlx5: Use eth_broadcast_addr() to assign broadcast address

On Mon, Jul 4, 2022 at 10:16 AM Xu Qiang <[email protected]> wrote:
>
> Using eth_broadcast_addr() to assign broadcast address instead
> of memset().
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Xu Qiang <[email protected]>

Acked-by: Jason Wang <[email protected]>

> ---
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index f738c78ef446..3b2929d4a819 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -1440,7 +1440,7 @@ static int mlx5_vdpa_add_mac_vlan_rules(struct mlx5_vdpa_net *ndev, u8 *mac,
> headers_v = MLX5_ADDR_OF(fte_match_param, spec->match_value, outer_headers);
> dmac_c = MLX5_ADDR_OF(fte_match_param, headers_c, outer_headers.dmac_47_16);
> dmac_v = MLX5_ADDR_OF(fte_match_param, headers_v, outer_headers.dmac_47_16);
> - memset(dmac_c, 0xff, ETH_ALEN);
> + eth_broadcast_addr(dmac_c);
> ether_addr_copy(dmac_v, mac);
> MLX5_SET(fte_match_set_lyr_2_4, headers_c, cvlan_tag, 1);
> if (tagged) {
> --
> 2.17.1
>