2022-07-04 15:24:27

by Marco Elver

Subject: [PATCH v3 03/14] perf/hw_breakpoint: Clean up headers

Clean up headers:

- Remove unused <linux/kallsyms.h>

- Remove unused <linux/kprobes.h>

- Remove unused <linux/module.h>

- Remove unused <linux/smp.h>

- Add <linux/export.h> for EXPORT_SYMBOL_GPL().

- Add <linux/mutex.h> for mutex.

- Sort alphabetically.

- Move <linux/hw_breakpoint.h> to top to test it compiles on its own.

Signed-off-by: Marco Elver <[email protected]>
Acked-by: Dmitry Vyukov <[email protected]>
---
v2:
* Move to start of series.
---
kernel/events/hw_breakpoint.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index fd5cd1f9e7fc..6076c6346291 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -17,23 +17,22 @@
* This file contains the arch-independent routines.
*/

+#include <linux/hw_breakpoint.h>
+
+#include <linux/bug.h>
+#include <linux/cpu.h>
+#include <linux/export.h>
+#include <linux/init.h>
#include <linux/irqflags.h>
-#include <linux/kallsyms.h>
-#include <linux/notifier.h>
-#include <linux/kprobes.h>
#include <linux/kdebug.h>
#include <linux/kernel.h>
-#include <linux/module.h>
+#include <linux/list.h>
+#include <linux/mutex.h>
+#include <linux/notifier.h>
#include <linux/percpu.h>
#include <linux/sched.h>
-#include <linux/init.h>
#include <linux/slab.h>
-#include <linux/list.h>
-#include <linux/cpu.h>
-#include <linux/smp.h>
-#include <linux/bug.h>

-#include <linux/hw_breakpoint.h>
/*
* Constraints data
*/
--
2.37.0.rc0.161.g10f37bed90-goog

2022-07-20 15:30:51

by Ian Rogers

Subject: Re: [PATCH v3 03/14] perf/hw_breakpoint: Clean up headers

On Mon, Jul 4, 2022 at 8:06 AM Marco Elver <[email protected]> wrote:
>
> Clean up headers:
>
> - Remove unused <linux/kallsyms.h>
>
> - Remove unused <linux/kprobes.h>
>
> - Remove unused <linux/module.h>
>
> - Remove unused <linux/smp.h>
>
> - Add <linux/export.h> for EXPORT_SYMBOL_GPL().
>
> - Add <linux/mutex.h> for mutex.
>
> - Sort alphabetically.
>
> - Move <linux/hw_breakpoint.h> to top to test it compiles on its own.
>
> Signed-off-by: Marco Elver <[email protected]>
> Acked-by: Dmitry Vyukov <[email protected]>

Acked-by: Ian Rogers <[email protected]>

Thanks,
Ian

> ---
> v2:
> * Move to start of series.
> ---
> kernel/events/hw_breakpoint.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
> index fd5cd1f9e7fc..6076c6346291 100644
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -17,23 +17,22 @@
> * This file contains the arch-independent routines.
> */
>
> +#include <linux/hw_breakpoint.h>
> +
> +#include <linux/bug.h>
> +#include <linux/cpu.h>
> +#include <linux/export.h>
> +#include <linux/init.h>
> #include <linux/irqflags.h>
> -#include <linux/kallsyms.h>
> -#include <linux/notifier.h>
> -#include <linux/kprobes.h>
> #include <linux/kdebug.h>
> #include <linux/kernel.h>
> -#include <linux/module.h>
> +#include <linux/list.h>
> +#include <linux/mutex.h>
> +#include <linux/notifier.h>
> #include <linux/percpu.h>
> #include <linux/sched.h>
> -#include <linux/init.h>
> #include <linux/slab.h>
> -#include <linux/list.h>
> -#include <linux/cpu.h>
> -#include <linux/smp.h>
> -#include <linux/bug.h>
>
> -#include <linux/hw_breakpoint.h>
> /*
> * Constraints data
> */
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>