2022-07-04 15:10:56

by Marco Elver

Subject: [PATCH v3 05/14] perf/hw_breakpoint: Mark data __ro_after_init

Mark read-only data after initialization as __ro_after_init.

While we are here, turn 'constraints_initialized' into a bool.

Signed-off-by: Marco Elver <[email protected]>
Reviewed-by: Dmitry Vyukov <[email protected]>
---
kernel/events/hw_breakpoint.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index 6d09edc80d19..7df46b276452 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -46,7 +46,7 @@ struct bp_cpuinfo {
};

static DEFINE_PER_CPU(struct bp_cpuinfo, bp_cpuinfo[TYPE_MAX]);
-static int nr_slots[TYPE_MAX];
+static int nr_slots[TYPE_MAX] __ro_after_init;

static struct bp_cpuinfo *get_bp_info(int cpu, enum bp_type_idx type)
{
@@ -62,7 +62,7 @@ static const struct rhashtable_params task_bps_ht_params = {
.automatic_shrinking = true,
};

-static int constraints_initialized;
+static bool constraints_initialized __ro_after_init;

/* Gather the number of total pinned and un-pinned bp in a cpuset */
struct bp_busy_slots {
@@ -739,7 +739,7 @@ int __init init_hw_breakpoint(void)
if (ret)
goto err;

- constraints_initialized = 1;
+ constraints_initialized = true;

perf_pmu_register(&perf_breakpoint, "breakpoint", PERF_TYPE_BREAKPOINT);

--
2.37.0.rc0.161.g10f37bed90-goog

2022-07-20 15:50:25

by Ian Rogers

Subject: Re: [PATCH v3 05/14] perf/hw_breakpoint: Mark data __ro_after_init

On Mon, Jul 4, 2022 at 8:06 AM Marco Elver <[email protected]> wrote:
>
> Mark read-only data after initialization as __ro_after_init.
>
> While we are here, turn 'constraints_initialized' into a bool.
>
> Signed-off-by: Marco Elver <[email protected]>
> Reviewed-by: Dmitry Vyukov <[email protected]>

Acked-by: Ian Rogers <[email protected]>

Thanks,
Ian

> ---
> kernel/events/hw_breakpoint.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
> index 6d09edc80d19..7df46b276452 100644
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -46,7 +46,7 @@ struct bp_cpuinfo {
> };
>
> static DEFINE_PER_CPU(struct bp_cpuinfo, bp_cpuinfo[TYPE_MAX]);
> -static int nr_slots[TYPE_MAX];
> +static int nr_slots[TYPE_MAX] __ro_after_init;
>
> static struct bp_cpuinfo *get_bp_info(int cpu, enum bp_type_idx type)
> {
> @@ -62,7 +62,7 @@ static const struct rhashtable_params task_bps_ht_params = {
> .automatic_shrinking = true,
> };
>
> -static int constraints_initialized;
> +static bool constraints_initialized __ro_after_init;
>
> /* Gather the number of total pinned and un-pinned bp in a cpuset */
> struct bp_busy_slots {
> @@ -739,7 +739,7 @@ int __init init_hw_breakpoint(void)
> if (ret)
> goto err;
>
> - constraints_initialized = 1;
> + constraints_initialized = true;
>
> perf_pmu_register(&perf_breakpoint, "breakpoint", PERF_TYPE_BREAKPOINT);
>
> --
> 2.37.0.rc0.161.g10f37bed90-goog
>