2022-06-30 22:34:58

by Sean Anderson

Subject: [PATCH v4 1/4] arm64: dts: ls1028a: Update SFP binding to include clock

The clocks property is now mandatory. Add it.

Fixes: eba5bea8f37f ("arm64: dts: ls1028a: add efuse node")
Signed-off-by: Sean Anderson <[email protected]>
Reviewed-by: Michael Walle <[email protected]>
---

(no changes since v1)

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 92465f777603..d5cdd77e5a95 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -224,9 +224,12 @@ rst: syscon@1e60000 {
little-endian;
};

- efuse@1e80000 {
+ sfp: efuse@1e80000 {
compatible = "fsl,ls1028a-sfp";
reg = <0x0 0x1e80000 0x0 0x10000>;
+ clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
+ QORIQ_CLK_PLL_DIV(4)>;
+ clock-names = "sfp";
#address-cells = <1>;
#size-cells = <1>;

--
2.35.1.1320.gc452695387.dirty

2022-07-04 08:47:21

by Krzysztof Kozlowski

Subject: Re: [PATCH v4 1/4] arm64: dts: ls1028a: Update SFP binding to include clock

On 01/07/2022 00:32, Sean Anderson wrote:
> The clocks property is now mandatory. Add it.
>
> Fixes: eba5bea8f37f ("arm64: dts: ls1028a: add efuse node")
> Signed-off-by: Sean Anderson <[email protected]>
> Reviewed-by: Michael Walle <[email protected]>

The subjects of all these 4 patches are confusing - you did not
update/add any binding here. These are not bindings.

Best regards,
Krzysztof

2022-07-05 01:16:26

by Shawn Guo

Subject: Re: [PATCH v4 1/4] arm64: dts: ls1028a: Update SFP binding to include clock

On Mon, Jul 04, 2022 at 10:27:40AM +0200, Krzysztof Kozlowski wrote:
> On 01/07/2022 00:32, Sean Anderson wrote:
> > The clocks property is now mandatory. Add it.
> >
> > Fixes: eba5bea8f37f ("arm64: dts: ls1028a: add efuse node")
> > Signed-off-by: Sean Anderson <[email protected]>
> > Reviewed-by: Michael Walle <[email protected]>
>
> The subjects of all these 4 patches are confusing - you did not
> update/add any binding here. These are not bindings.

Right, I replaced 'binding' with 'node' during applying.

Shawn