2022-07-05 03:22:18

by Xiubo Li

[permalink] [raw]
Subject: [PATCH v2 2/2] afs: unlock the folio when vnode is marked deleted

From: Xiubo Li <[email protected]>

The check_write_begin() should unlock the folio if return non-zero,
otherwise locked.

URL: https://tracker.ceph.com/issues/56423
Signed-off-by: Xiubo Li <[email protected]>
---
fs/afs/file.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/fs/afs/file.c b/fs/afs/file.c
index 42118a4f3383..5a9ed181d724 100644
--- a/fs/afs/file.c
+++ b/fs/afs/file.c
@@ -379,7 +379,13 @@ static int afs_check_write_begin(struct file *file, loff_t pos, unsigned len,
{
struct afs_vnode *vnode = AFS_FS_I(file_inode(file));

- return test_bit(AFS_VNODE_DELETED, &vnode->flags) ? -ESTALE : 0;
+ if (test_bit(AFS_VNODE_DELETED, &vnode->flags)) {
+ folio_unlock(folio);
+ folio_put(folio);
+ return -ESTALE;
+ }
+
+ return 0;
}

static void afs_free_request(struct netfs_io_request *rreq)
--
2.36.0.rc1