2022-07-06 01:53:19

by Li zeming

[permalink] [raw]
Subject: [PATCH] acpi/sleep: Add header file macro definition

Add header file macro definition.

Signed-off-by: Li zeming <[email protected]>
---
drivers/acpi/sleep.h | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/acpi/sleep.h b/drivers/acpi/sleep.h
index 7fe41ee489d6..adb3b5c13f90 100644
--- a/drivers/acpi/sleep.h
+++ b/drivers/acpi/sleep.h
@@ -1,4 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _SLEEP_H
+#define _SLEEP_H

extern void acpi_enable_wakeup_devices(u8 sleep_state);
extern void acpi_disable_wakeup_devices(u8 sleep_state);
@@ -30,3 +32,5 @@ extern bool acpi_sleep_default_s3;
#else
#define acpi_sleep_default_s3 (1)
#endif
+
+#endif
--
2.18.2


2022-07-06 10:41:23

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] acpi/sleep: Add header file macro definition

On Wed, Jul 6, 2022 at 3:44 AM Li zeming <[email protected]> wrote:
>
> Add header file macro definition.

Please explain why you want to make this change.

> Signed-off-by: Li zeming <[email protected]>
> ---
> drivers/acpi/sleep.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/acpi/sleep.h b/drivers/acpi/sleep.h
> index 7fe41ee489d6..adb3b5c13f90 100644
> --- a/drivers/acpi/sleep.h
> +++ b/drivers/acpi/sleep.h
> @@ -1,4 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _SLEEP_H
> +#define _SLEEP_H
>
> extern void acpi_enable_wakeup_devices(u8 sleep_state);
> extern void acpi_disable_wakeup_devices(u8 sleep_state);
> @@ -30,3 +32,5 @@ extern bool acpi_sleep_default_s3;
> #else
> #define acpi_sleep_default_s3 (1)
> #endif
> +
> +#endif
> --
> 2.18.2
>

2022-07-07 01:29:55

by Li zeming

[permalink] [raw]
Subject: Re: [PATCH] acpi/sleep: Add header file macro definition


I think the header file could avoid redefinition errors.
at compile time by adding macro definitions.