2022-07-06 10:33:22

by Srinivas Kandagatla

Subject: [PATCH 0/2] slimbus: patches for 5.20

Hi Greg,
Here are some trivial SlimBus patches for 5.20,

One of them is to do with typos in comments and other one is to move to
ida_alloc apis from old deprecated ida_simple apis.

Can you please queue them up for 5.20.

Thanks,
Srini

Julia Lawall (1):
slimbus: messaging: fix typos in comments

keliu (1):
drivers: slimbus: Directly use ida_alloc()/free()

drivers/slimbus/core.c | 6 +++---
drivers/slimbus/messaging.c | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)

--
2.25.1

2022-07-06 10:40:35

by Srinivas Kandagatla

Subject: [PATCH 1/2] drivers: slimbus: Directly use ida_alloc()/free()

From: keliu <[email protected]>

Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .

Signed-off-by: keliu <[email protected]>
Signed-off-by: Srinivas Kandagatla <[email protected]>
---
drivers/slimbus/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c
index 78480e332ab8..219483b79c09 100644
--- a/drivers/slimbus/core.c
+++ b/drivers/slimbus/core.c
@@ -250,7 +250,7 @@ int slim_register_controller(struct slim_controller *ctrl)
{
int id;

- id = ida_simple_get(&ctrl_ida, 0, 0, GFP_KERNEL);
+ id = ida_alloc(&ctrl_ida, GFP_KERNEL);
if (id < 0)
return id;

@@ -299,7 +299,7 @@ int slim_unregister_controller(struct slim_controller *ctrl)
{
/* Remove all clients */
device_for_each_child(ctrl->dev, NULL, slim_ctrl_remove_device);
- ida_simple_remove(&ctrl_ida, ctrl->id);
+ ida_free(&ctrl_ida, ctrl->id);

return 0;
}
@@ -323,7 +323,7 @@ void slim_report_absent(struct slim_device *sbdev)
sbdev->is_laddr_valid = false;
mutex_unlock(&ctrl->lock);
if (!ctrl->get_laddr)
- ida_simple_remove(&ctrl->laddr_ida, sbdev->laddr);
+ ida_free(&ctrl->laddr_ida, sbdev->laddr);
slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_DOWN);
}
EXPORT_SYMBOL_GPL(slim_report_absent);
--
2.25.1