2022-07-06 11:58:28

by Usyskin, Alexander

Subject: [PATCH v5 02/14] drm/i915/gsc: add slow_fw flag to the mei auxiliary device

Add slow_fw flag to the mei auxiliary device info
to inform the mei driver about slow underlying firmware.
Such firmware will require to use larger operation timeouts.

Signed-off-by: Alexander Usyskin <[email protected]>
Signed-off-by: Tomas Winkler <[email protected]>
Reviewed-by: Daniele Ceraolo Spurio <[email protected]>
---
include/linux/mei_aux.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
index 587f25128848..a29f4064b9c0 100644
--- a/include/linux/mei_aux.h
+++ b/include/linux/mei_aux.h
@@ -11,6 +11,7 @@ struct mei_aux_device {
struct auxiliary_device aux_dev;
int irq;
struct resource bar;
+ bool slow_fw;
};

#define auxiliary_dev_to_mei_aux_dev(auxiliary_dev) \
--
2.34.1

2022-07-07 15:37:14

by Rodrigo Vivi

Subject: Re: [PATCH v5 02/14] drm/i915/gsc: add slow_fw flag to the mei auxiliary device

On Wed, Jul 06, 2022 at 02:43:33PM +0300, Alexander Usyskin wrote:
> Add slow_fw flag to the mei auxiliary device info
> to inform the mei driver about slow underlying firmware.
> Such firmware will require to use larger operation timeouts.
>
> Signed-off-by: Alexander Usyskin <[email protected]>
> Signed-off-by: Tomas Winkler <[email protected]>
> Reviewed-by: Daniele Ceraolo Spurio <[email protected]>
> ---
> include/linux/mei_aux.h | 1 +

This patch has a wrong subject since it doesn't touch i915.

> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h
> index 587f25128848..a29f4064b9c0 100644
> --- a/include/linux/mei_aux.h
> +++ b/include/linux/mei_aux.h
> @@ -11,6 +11,7 @@ struct mei_aux_device {
> struct auxiliary_device aux_dev;
> int irq;
> struct resource bar;
> + bool slow_fw;
> };
>
> #define auxiliary_dev_to_mei_aux_dev(auxiliary_dev) \
> --
> 2.34.1
>

2022-07-18 14:14:08

by Winkler, Tomas

Subject: RE: [PATCH v5 02/14] drm/i915/gsc: add slow_fw flag to the mei auxiliary device

>
> On Wed, Jul 06, 2022 at 02:43:33PM +0300, Alexander Usyskin wrote:
> > Add slow_fw flag to the mei auxiliary device info to inform the mei
> > driver about slow underlying firmware.
> > Such firmware will require to use larger operation timeouts.
> >
> > Signed-off-by: Alexander Usyskin <[email protected]>
> > Signed-off-by: Tomas Winkler <[email protected]>
> > Reviewed-by: Daniele Ceraolo Spurio <[email protected]>
> > ---
> > include/linux/mei_aux.h | 1 +
>
> This patch has a wrong subject since it doesn't touch i915.

This is in a shared file between drm and mei, but I can resend.

>
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/mei_aux.h b/include/linux/mei_aux.h index
> > 587f25128848..a29f4064b9c0 100644
> > --- a/include/linux/mei_aux.h
> > +++ b/include/linux/mei_aux.h
> > @@ -11,6 +11,7 @@ struct mei_aux_device {
> > struct auxiliary_device aux_dev;
> > int irq;
> > struct resource bar;
> > + bool slow_fw;
> > };
> >
> > #define auxiliary_dev_to_mei_aux_dev(auxiliary_dev) \
> > --
> > 2.34.1
> >