2022-07-06 18:39:39

by T.J. Mercier

Subject: [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset

The docs explicitly say the drm_gem_object_release function already calls this,
and this does not appear to be a prerequisite for the call to
etnaviv_gem_ops.release.

Signed-off-by: T.J. Mercier <[email protected]>
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index cc386f8a7116..ecb828e4e156 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -504,7 +504,6 @@ void etnaviv_gem_free_object(struct drm_gem_object *obj)
kfree(mapping);
}

- drm_gem_free_mmap_offset(obj);
etnaviv_obj->ops->release(etnaviv_obj);
drm_gem_object_release(obj);

--
2.37.0.rc0.161.g10f37bed90-goog

2022-08-19 17:40:33

by Lucas Stach

Subject: Re: [PATCH] drm/etnaviv: Remove duplicate call to drm_gem_free_mmap_offset

Am Mittwoch, dem 06.07.2022 um 18:29 +0000 schrieb T.J. Mercier:
> The docs explicitly say the drm_gem_object_release function already calls this,
> and this does not appear to be a prerequisite for the call to
> etnaviv_gem_ops.release.
>
This looks correct to me. Patch applied to etnaviv/next.

Regards,
Lucas

> Signed-off-by: T.J. Mercier <[email protected]>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index cc386f8a7116..ecb828e4e156 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -504,7 +504,6 @@ void etnaviv_gem_free_object(struct drm_gem_object *obj)
> kfree(mapping);
> }
>
> - drm_gem_free_mmap_offset(obj);
> etnaviv_obj->ops->release(etnaviv_obj);
> drm_gem_object_release(obj);
>