2022-07-07 07:20:55

by Lars-Peter Clausen

Subject: [PATCH 1/2] phy: cadence: Sierra: Remove unused `regmap` field from state struct

The driver state struct for the sierra PHY driver has a field named
`regmap` that is never referenced. Remove it since it is unused.

Not that there are separate fields of type `struct regmap` for the
individual sections of the device's register map. These other regmaps are
used and not affected by the patch.

Signed-off-by: Lars-Peter Clausen <[email protected]>
---
drivers/phy/cadence/phy-cadence-sierra.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
index 73fb99ccd525..6e86a6517f37 100644
--- a/drivers/phy/cadence/phy-cadence-sierra.c
+++ b/drivers/phy/cadence/phy-cadence-sierra.c
@@ -348,7 +348,6 @@ struct cdns_regmap_cdb_context {

struct cdns_sierra_phy {
struct device *dev;
- struct regmap *regmap;
const struct cdns_sierra_data *init_data;
struct cdns_sierra_inst phys[SIERRA_MAX_LANES];
struct reset_control *phy_rst;
--
2.30.2

2022-07-07 07:21:05

by Lars-Peter Clausen

Subject: [PATCH 2/2] phy: cadence-torrent: Remove unused `regmap` field from state struct

The driver state struct for the sierra PHY driver has a field named
`regmap` that is never referenced. Remove it since it is unused.

Not that there are separate fields of type `struct regmap` for the
individual sections of the device's register map. These other regmaps are
used and not affected by the patch.

Signed-off-by: Lars-Peter Clausen <[email protected]>
---
drivers/phy/cadence/phy-cadence-torrent.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/phy/cadence/phy-cadence-torrent.c b/drivers/phy/cadence/phy-cadence-torrent.c
index 7c4b8050485f..f099053c583c 100644
--- a/drivers/phy/cadence/phy-cadence-torrent.c
+++ b/drivers/phy/cadence/phy-cadence-torrent.c
@@ -331,7 +331,6 @@ struct cdns_torrent_phy {
struct cdns_torrent_inst phys[MAX_NUM_LANES];
int nsubnodes;
const struct cdns_torrent_data *init_data;
- struct regmap *regmap;
struct regmap *regmap_common_cdb;
struct regmap *regmap_phy_pcs_common_cdb;
struct regmap *regmap_phy_pma_common_cdb;
--
2.30.2

2022-07-08 05:40:38

by Vinod Koul

Subject: Re: [PATCH 1/2] phy: cadence: Sierra: Remove unused `regmap` field from state struct

On 07-07-22, 09:17, Lars-Peter Clausen wrote:
> The driver state struct for the sierra PHY driver has a field named
> `regmap` that is never referenced. Remove it since it is unused.
>
> Not that there are separate fields of type `struct regmap` for the
> individual sections of the device's register map. These other regmaps are
> used and not affected by the patch.

Applied both, thanks

--
~Vinod