2022-07-08 02:03:32

by Souptick Joarder

Subject: [PATCH] NTB: EPF: Mark pci_read and pci_write as static

From: "Souptick Joarder (HPE)" <[email protected]>

kernel test robot throws below warning ->

drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
no previous prototype for 'pci_read' [-Wmissing-prototypes]
drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
no previous prototype for 'pci_write' [-Wmissing-prototypes]

mark them as static.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Souptick Joarder (HPE) <[email protected]>
---
drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
index ebf7e243eefa..111568089d45 100644
--- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
+++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
@@ -972,7 +972,7 @@ uint32_t pci_space[] = {
0, //Max Lat, Min Gnt, interrupt pin, interrupt line
};

-int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
+static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
{
if (devfn == 0) {
memcpy(val, ((uint8_t *)pci_space) + where, size);
@@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
return -1;
}

-int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
+static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
{
return 0;
}
--
2.25.1

2022-07-12 19:56:20

by Bjorn Helgaas

Subject: Re: [PATCH] NTB: EPF: Mark pci_read and pci_write as static

On Fri, Jul 08, 2022 at 07:30:35AM +0530, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <[email protected]>
>
> kernel test robot throws below warning ->
>
> drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
> no previous prototype for 'pci_read' [-Wmissing-prototypes]
> drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
> no previous prototype for 'pci_write' [-Wmissing-prototypes]
>
> mark them as static.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Souptick Joarder (HPE) <[email protected]>

IIUC this series is going via Jon. Let me know if I need to do
anything.

> ---
> drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> index ebf7e243eefa..111568089d45 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> @@ -972,7 +972,7 @@ uint32_t pci_space[] = {
> 0, //Max Lat, Min Gnt, interrupt pin, interrupt line
> };
>
> -int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
> +static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
> {
> if (devfn == 0) {
> memcpy(val, ((uint8_t *)pci_space) + where, size);
> @@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
> return -1;
> }
>
> -int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
> +static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
> {
> return 0;
> }
> --
> 2.25.1
>

2022-08-12 14:27:22

by Jon Mason

Subject: Re: [PATCH] NTB: EPF: Mark pci_read and pci_write as static

On Tue, Jul 12, 2022 at 02:49:36PM -0500, Bjorn Helgaas wrote:
> On Fri, Jul 08, 2022 at 07:30:35AM +0530, Souptick Joarder wrote:
> > From: "Souptick Joarder (HPE)" <[email protected]>
> >
> > kernel test robot throws below warning ->
> >
> > drivers/pci/endpoint/functions/pci-epf-vntb.c:975:5: warning:
> > no previous prototype for 'pci_read' [-Wmissing-prototypes]
> > drivers/pci/endpoint/functions/pci-epf-vntb.c:984:5: warning:
> > no previous prototype for 'pci_write' [-Wmissing-prototypes]
> >
> > mark them as static.
> >
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Souptick Joarder (HPE) <[email protected]>
>
> IIUC this series is going via Jon. Let me know if I need to do
> anything.

Sorry for the extremely long delay in response. This series is in my
ntb branch and will be in my pull request for v5.20 which should be
going out later today.

Thanks,
Jon

>
> > ---
> > drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > index ebf7e243eefa..111568089d45 100644
> > --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c
> > @@ -972,7 +972,7 @@ uint32_t pci_space[] = {
> > 0, //Max Lat, Min Gnt, interrupt pin, interrupt line
> > };
> >
> > -int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
> > +static int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *val)
> > {
> > if (devfn == 0) {
> > memcpy(val, ((uint8_t *)pci_space) + where, size);
> > @@ -981,7 +981,7 @@ int pci_read(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 *
> > return -1;
> > }
> >
> > -int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
> > +static int pci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val)
> > {
> > return 0;
> > }
> > --
> > 2.25.1
> >