2022-07-08 04:41:46

by Zhongjun Tan

Subject: [PATCH] iavf: Remove condition with no effect

From: Zhongjun Tan <[email protected]>

Remove condition with no effect

Signed-off-by: Zhongjun Tan <[email protected]>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 69ade653f5d4..52b622ea7d6b 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -2136,8 +2136,6 @@ iavf_set_vlan_offload_features(struct iavf_adapter *adapter,
vlan_ethertype = ETH_P_8021Q;
else if (prev_features & (NETIF_F_HW_VLAN_STAG_RX | NETIF_F_HW_VLAN_STAG_TX))
vlan_ethertype = ETH_P_8021AD;
- else if (prev_features & (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_CTAG_TX))
- vlan_ethertype = ETH_P_8021Q;
else
vlan_ethertype = ETH_P_8021Q;

--
2.29.0

2022-07-08 22:45:35

by Jakub Kicinski

Subject: Re: [PATCH] iavf: Remove condition with no effect

On Fri, 8 Jul 2022 11:51:54 +0800 Zhongjun Tan wrote:
> From: Zhongjun Tan <[email protected]>
>
> Remove condition with no effect

The code is fine, please fix the tool you're using to not generate such
patches.