2022-07-08 05:40:10

by Keoseong Park

Subject: [PATCH] scsi: ufs: core: Remove UIC_HIBERN8_ENTER_RETRIES

Commit 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler
and other error recovery paths") removed all callers of
UIC_HIBERN8_ENTER_RETRIES. Hence also remove the macro itself.

Signed-off-by: Keoseong Park <[email protected]>
---
drivers/ufs/core/ufshcd.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 1d3214e6b364..f6b36d2bfa21 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -64,9 +64,6 @@
/* maximum number of link-startup retries */
#define DME_LINKSTARTUP_RETRIES 3

-/* Maximum retries for Hibern8 enter */
-#define UIC_HIBERN8_ENTER_RETRIES 3
-
/* maximum number of reset retries before giving up */
#define MAX_HOST_RESET_RETRIES 5

--
2.17.1

2022-07-08 08:57:54

by Avri Altman

Subject: RE: [PATCH] scsi: ufs: core: Remove UIC_HIBERN8_ENTER_RETRIES

> Commit 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and other
> error recovery paths") removed all callers of UIC_HIBERN8_ENTER_RETRIES.
> Hence also remove the macro itself.
>
> Signed-off-by: Keoseong Park <[email protected]>
Reviewed-by: Avri Altman <[email protected]>

> ---
> drivers/ufs/core/ufshcd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> 1d3214e6b364..f6b36d2bfa21 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -64,9 +64,6 @@
> /* maximum number of link-startup retries */ #define
> DME_LINKSTARTUP_RETRIES 3
>
> -/* Maximum retries for Hibern8 enter */ -#define
> UIC_HIBERN8_ENTER_RETRIES 3
> -
> /* maximum number of reset retries before giving up */ #define
> MAX_HOST_RESET_RETRIES 5
>
> --
> 2.17.1

2022-07-14 03:31:17

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: core: Remove UIC_HIBERN8_ENTER_RETRIES

Keoseong,

> Commit 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and
> other error recovery paths") removed all callers of
> UIC_HIBERN8_ENTER_RETRIES. Hence also remove the macro itself.

Applied to 5.20/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2022-07-19 03:27:29

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: core: Remove UIC_HIBERN8_ENTER_RETRIES

On Fri, 08 Jul 2022 14:20:06 +0900, Keoseong Park wrote:

> Commit 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler
> and other error recovery paths") removed all callers of
> UIC_HIBERN8_ENTER_RETRIES. Hence also remove the macro itself.
>
>

Applied to 5.20/scsi-queue, thanks!

[1/1] scsi: ufs: core: Remove UIC_HIBERN8_ENTER_RETRIES
https://git.kernel.org/mkp/scsi/c/c641ffdb5904

--
Martin K. Petersen Oracle Linux Engineering