2022-07-12 12:27:53

by Viswanath Boma

Subject: [PATCH 5/7] venus : Addition of support for VIDIOC_TRY_ENCODER_CMD

From: Dikshita Agarwal <[email protected]>

v4l2 compliance expecting support for vidioc_try_encoder_cmd
error details : test VIDIOC_(TRY_)ENCODER_CMD: FAIL

Change-Id: I87a655dc506f3e713e2c86ab5203ca9c45cc5e1b
Signed-off-by: Viswanath Boma <[email protected]>
---
drivers/media/platform/qcom/venus/venc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
index 30ddb84c24997..4f10f5de7e3e6 100644
--- a/drivers/media/platform/qcom/venus/venc.c
+++ b/drivers/media/platform/qcom/venus/venc.c
@@ -589,6 +589,7 @@ static const struct v4l2_ioctl_ops venc_ioctl_ops = {
.vidioc_subscribe_event = venc_subscribe_event,
.vidioc_unsubscribe_event = v4l2_event_unsubscribe,
.vidioc_encoder_cmd = venc_encoder_cmd,
+ .vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd,
};

static int venc_pm_get(struct venus_inst *inst)
--
2.17.1

2022-07-26 10:46:56

by Stanimir Varbanov

Subject: Re: [PATCH 5/7] venus : Addition of support for VIDIOC_TRY_ENCODER_CMD

On 7/12/22 15:23, Viswanath Boma wrote:
> From: Dikshita Agarwal <[email protected]>
>
> v4l2 compliance expecting support for vidioc_try_encoder_cmd
> error details : test VIDIOC_(TRY_)ENCODER_CMD: FAIL
>
> Change-Id: I87a655dc506f3e713e2c86ab5203ca9c45cc5e1b

Drop Change-Id and add Dikshita's Signed-off tag.

> Signed-off-by: Viswanath Boma <[email protected]>
> ---
> drivers/media/platform/qcom/venus/venc.c | 1 +
> 1 file changed, 1 insertion(+)

With above comments fixed you can add my:

Acked-by: Stanimir Varbanov <[email protected]>

>
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index 30ddb84c24997..4f10f5de7e3e6 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -589,6 +589,7 @@ static const struct v4l2_ioctl_ops venc_ioctl_ops = {
> .vidioc_subscribe_event = venc_subscribe_event,
> .vidioc_unsubscribe_event = v4l2_event_unsubscribe,
> .vidioc_encoder_cmd = venc_encoder_cmd,
> + .vidioc_try_encoder_cmd = v4l2_m2m_ioctl_try_encoder_cmd,
> };
>
> static int venc_pm_get(struct venus_inst *inst)

--
regards,
Stan