tree: https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
head: 40d1ef717dd762939c0a8734fd901ee517b50334
commit: 40d1ef717dd762939c0a8734fd901ee517b50334 [20/20] xen-blkback: fix persistent grants negotiation
config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220712/[email protected]/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project badda4ac3c489a8c8cccdad1f74b9308c350a9e0)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?id=40d1ef717dd762939c0a8734fd901ee517b50334
git remote add sj https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git
git fetch --no-tags sj damon/next
git checkout 40d1ef717dd762939c0a8734fd901ee517b50334
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/block/xen-blkback/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
>> drivers/block/xen-blkback/xenbus.c:184:38: error: use of undeclared identifier 'feature_persistent'
blkif->vbd.feature_gnt_persistent = feature_persistent;
^
1 error generated.
vim +/feature_persistent +184 drivers/block/xen-blkback/xenbus.c
159
160 static struct xen_blkif *xen_blkif_alloc(domid_t domid)
161 {
162 struct xen_blkif *blkif;
163
164 BUILD_BUG_ON(MAX_INDIRECT_PAGES > BLKIF_MAX_INDIRECT_PAGES_PER_REQUEST);
165
166 blkif = kmem_cache_zalloc(xen_blkif_cachep, GFP_KERNEL);
167 if (!blkif)
168 return ERR_PTR(-ENOMEM);
169
170 blkif->domid = domid;
171 atomic_set(&blkif->refcnt, 1);
172 init_completion(&blkif->drain_complete);
173
174 /*
175 * Because freeing back to the cache may be deferred, it is not
176 * safe to unload the module (and hence destroy the cache) until
177 * this has completed. To prevent premature unloading, take an
178 * extra module reference here and release only when the object
179 * has been freed back to the cache.
180 */
181 __module_get(THIS_MODULE);
182 INIT_WORK(&blkif->free_work, xen_blkif_deferred_free);
183
> 184 blkif->vbd.feature_gnt_persistent = feature_persistent;
185
186 return blkif;
187 }
188
--
0-DAY CI Kernel Test Service
https://01.org/lkp
On Tue, 12 Jul 2022 14:22:23 +0800 kernel test robot <[email protected]> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git damon/next
> head: 40d1ef717dd762939c0a8734fd901ee517b50334
> commit: 40d1ef717dd762939c0a8734fd901ee517b50334 [20/20] xen-blkback: fix persistent grants negotiation
> config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220712/[email protected]/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project badda4ac3c489a8c8cccdad1f74b9308c350a9e0)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/commit/?id=40d1ef717dd762939c0a8734fd901ee517b50334
> git remote add sj https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git
> git fetch --no-tags sj damon/next
> git checkout 40d1ef717dd762939c0a8734fd901ee517b50334
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/block/xen-blkback/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> >> drivers/block/xen-blkback/xenbus.c:184:38: error: use of undeclared identifier 'feature_persistent'
> blkif->vbd.feature_gnt_persistent = feature_persistent;
> ^
> 1 error generated.
Thank you for the report. I fixed it as below and pushed:
+/* Enable the persistent grants feature. */
+static bool feature_persistent = true;
+module_param(feature_persistent, bool, 0644);
+MODULE_PARM_DESC(feature_persistent, "Enables the persistent grants feature");
+
static struct xen_blkif *xen_blkif_alloc(domid_t domid)
{
struct xen_blkif *blkif;
@@ -474,12 +479,6 @@ static void xen_vbd_free(struct xen_vbd *vbd)
vbd->bdev = NULL;
}
-/* Enable the persistent grants feature. */
-static bool feature_persistent = true;
-module_param(feature_persistent, bool, 0644);
-MODULE_PARM_DESC(feature_persistent,
- "Enables the persistent grants feature");
-
static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
unsigned major, unsigned minor, int readonly,
int cdrom)
Note: The commit is only for my personal test at the moment.
[...]