USB PD controllers which consisting of a microcontroller (acting as the TCPM)
and a port controller (TCPC) - may require that the driver for the PD
controller accesses directly also the on-chip port controller in some cases.
Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
Reviewed-by: Guenter Roeck <[email protected]>
Reviewed-by: Heikki Krogerus <[email protected]>
Signed-off-by: Xin Ji <[email protected]>
---
V9 -> V10: Rebase on the latest code
V8 -> V9 : Add more commit message
V7 -> V8 : Fix Guanter's comment, remove unnecessary explain
---
drivers/usb/typec/tcpm/tcpci.c | 3 +--
drivers/usb/typec/tcpm/tcpci_maxim.c | 3 +--
drivers/usb/typec/tcpm/tcpci_mt6360.c | 3 +--
drivers/usb/typec/tcpm/tcpci_rt1711h.c | 2 +-
{drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h | 1 +
5 files changed, 5 insertions(+), 7 deletions(-)
rename {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h (99%)
diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
index f33e08eb7670..812784702d53 100644
--- a/drivers/usb/typec/tcpm/tcpci.c
+++ b/drivers/usb/typec/tcpm/tcpci.c
@@ -13,11 +13,10 @@
#include <linux/property.h>
#include <linux/regmap.h>
#include <linux/usb/pd.h>
+#include <linux/usb/tcpci.h>
#include <linux/usb/tcpm.h>
#include <linux/usb/typec.h>
-#include "tcpci.h"
-
#define PD_RETRY_COUNT_DEFAULT 3
#define PD_RETRY_COUNT_3_0_OR_HIGHER 2
#define AUTO_DISCHARGE_DEFAULT_THRESHOLD_MV 3500
diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
index df2505570f07..4b6705f3d7b7 100644
--- a/drivers/usb/typec/tcpm/tcpci_maxim.c
+++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
@@ -11,11 +11,10 @@
#include <linux/module.h>
#include <linux/regmap.h>
#include <linux/usb/pd.h>
+#include <linux/usb/tcpci.h>
#include <linux/usb/tcpm.h>
#include <linux/usb/typec.h>
-#include "tcpci.h"
-
#define PD_ACTIVITY_TIMEOUT_MS 10000
#define TCPC_VENDOR_ALERT 0x80
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
index 8a952eaf9016..1b7c31278ebb 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
@@ -11,10 +11,9 @@
#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
+#include <linux/usb/tcpci.h>
#include <linux/usb/tcpm.h>
-#include "tcpci.h"
-
#define MT6360_REG_PHYCTRL1 0x80
#define MT6360_REG_PHYCTRL3 0x82
#define MT6360_REG_PHYCTRL7 0x86
diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
index b56a0880a044..3291ca4948da 100644
--- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
+++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
@@ -10,9 +10,9 @@
#include <linux/i2c.h>
#include <linux/interrupt.h>
#include <linux/gpio/consumer.h>
+#include <linux/usb/tcpci.h>
#include <linux/usb/tcpm.h>
#include <linux/regmap.h>
-#include "tcpci.h"
#define RT1711H_VID 0x29CF
#define RT1711H_PID 0x1711
diff --git a/drivers/usb/typec/tcpm/tcpci.h b/include/linux/usb/tcpci.h
similarity index 99%
rename from drivers/usb/typec/tcpm/tcpci.h
rename to include/linux/usb/tcpci.h
index b2edd45f13c6..20c0bedb8ec8 100644
--- a/drivers/usb/typec/tcpm/tcpci.h
+++ b/include/linux/usb/tcpci.h
@@ -9,6 +9,7 @@
#define __LINUX_USB_TCPCI_H
#include <linux/usb/typec.h>
+#include <linux/usb/tcpm.h>
#define TCPC_VENDOR_ID 0x0
#define TCPC_PRODUCT_ID 0x2
--
2.25.1
Add analogix PD chip anx7411 device binding
Reviewed-by: Rob Herring <[email protected]>
Signed-off-by: Xin Ji <[email protected]>
---
v13 -> v14 :
1. Fix Robot compile error. Fix node name not correct.
2. Change HEX to lowercase.
3. Use "ports" property.
v12 -> v13 :
1. Drop the quotes for "$id" and "$schema"
2. Remove "allOf" label
3. Change node name from "i2c1" to "i2c"
4. Change node name from "typec" to "usb-typec"
Signed-off-by: Xin Ji <[email protected]>
---
.../bindings/usb/analogix,anx7411.yaml | 81 +++++++++++++++++++
1 file changed, 81 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
new file mode 100644
index 000000000000..bbd071ba338f
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
@@ -0,0 +1,81 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/analogix,anx7411.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analogix ANX7411 Type-C controller bindings
+
+maintainers:
+ - Xin Ji <[email protected]>
+
+properties:
+ compatible:
+ enum:
+ - analogix,anx7411
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ connector:
+ type: object
+ $ref: ../connector/usb-connector.yaml
+ description:
+ Properties for usb c connector.
+
+ properties:
+ compatible:
+ const: usb-c-connector
+
+ power-role: true
+
+ data-role: true
+
+ try-power-role: true
+
+ required:
+ - compatible
+
+required:
+ - compatible
+ - reg
+ - connector
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ anx7411@2c {
+ compatible = "analogix,anx7411";
+ reg = <0x2c>;
+ interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
+ interrupt-parent = <&gpio0>;
+
+ typec_con: connector {
+ compatible = "usb-c-connector";
+ power-role = "dual";
+ data-role = "dual";
+ try-power-role = "source";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ typec_con_ep: endpoint {
+ remote-endpoint = <&usbotg_hs_ep>;
+ };
+ };
+ };
+ };
+ };
+ };
+...
--
2.25.1
On 12/07/2022 11:05, Xin Ji wrote:
> Add analogix PD chip anx7411 device binding
>
> Reviewed-by: Rob Herring <[email protected]>
> Signed-off-by: Xin Ji <[email protected]>
>
> ---
> v13 -> v14 :
> 1. Fix Robot compile error. Fix node name not correct.
Node name is still not correct.
> 2. Change HEX to lowercase.
> 3. Use "ports" property.
> v12 -> v13 :
> 1. Drop the quotes for "$id" and "$schema"
> 2. Remove "allOf" label
> 3. Change node name from "i2c1" to "i2c"
> 4. Change node name from "typec" to "usb-typec"
>
> Signed-off-by: Xin Ji <[email protected]>
> ---
> .../bindings/usb/analogix,anx7411.yaml | 81 +++++++++++++++++++
> 1 file changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> new file mode 100644
> index 000000000000..bbd071ba338f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/analogix,anx7411.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analogix ANX7411 Type-C controller bindings
> +
> +maintainers:
> + - Xin Ji <[email protected]>
> +
> +properties:
> + compatible:
> + enum:
> + - analogix,anx7411
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + connector:
> + type: object
> + $ref: ../connector/usb-connector.yaml
> + description:
> + Properties for usb c connector.
> +
> + properties:
> + compatible:
> + const: usb-c-connector
> +
> + power-role: true
> +
> + data-role: true
> +
> + try-power-role: true
> +
> + required:
> + - compatible
> +
> +required:
> + - compatible
> + - reg
> + - connector
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + anx7411@2c {
Use generic node name:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "analogix,anx7411";
> + reg = <0x2c>;
> + interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> + interrupt-parent = <&gpio0>;
> +
> + typec_con: connector {
> + compatible = "usb-c-connector";
> + power-role = "dual";
> + data-role = "dual";
> + try-power-role = "source";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + typec_con_ep: endpoint {
> + remote-endpoint = <&usbotg_hs_ep>;
> + };
> + };
> + };
> + };
> + };
> + };
> +...
Best regards,
Krzysztof
On 7/12/22 02:05, Xin Ji wrote:
> USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> and a port controller (TCPC) - may require that the driver for the PD
> controller accesses directly also the on-chip port controller in some cases.
>
> Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
>
> Reviewed-by: Guenter Roeck <[email protected]>
> Reviewed-by: Heikki Krogerus <[email protected]>
> Signed-off-by: Xin Ji <[email protected]>
>
> ---
> V9 -> V10: Rebase on the latest code
> V8 -> V9 : Add more commit message
> V7 -> V8 : Fix Guanter's comment, remove unnecessary explain
We are now at v16. The change log has not been updated since v10,
making it all but worthless.
Guenter
> ---
> drivers/usb/typec/tcpm/tcpci.c | 3 +--
> drivers/usb/typec/tcpm/tcpci_maxim.c | 3 +--
> drivers/usb/typec/tcpm/tcpci_mt6360.c | 3 +--
> drivers/usb/typec/tcpm/tcpci_rt1711h.c | 2 +-
> {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h | 1 +
> 5 files changed, 5 insertions(+), 7 deletions(-)
> rename {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h (99%)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
> index f33e08eb7670..812784702d53 100644
> --- a/drivers/usb/typec/tcpm/tcpci.c
> +++ b/drivers/usb/typec/tcpm/tcpci.c
> @@ -13,11 +13,10 @@
> #include <linux/property.h>
> #include <linux/regmap.h>
> #include <linux/usb/pd.h>
> +#include <linux/usb/tcpci.h>
> #include <linux/usb/tcpm.h>
> #include <linux/usb/typec.h>
>
> -#include "tcpci.h"
> -
> #define PD_RETRY_COUNT_DEFAULT 3
> #define PD_RETRY_COUNT_3_0_OR_HIGHER 2
> #define AUTO_DISCHARGE_DEFAULT_THRESHOLD_MV 3500
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index df2505570f07..4b6705f3d7b7 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -11,11 +11,10 @@
> #include <linux/module.h>
> #include <linux/regmap.h>
> #include <linux/usb/pd.h>
> +#include <linux/usb/tcpci.h>
> #include <linux/usb/tcpm.h>
> #include <linux/usb/typec.h>
>
> -#include "tcpci.h"
> -
> #define PD_ACTIVITY_TIMEOUT_MS 10000
>
> #define TCPC_VENDOR_ALERT 0x80
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index 8a952eaf9016..1b7c31278ebb 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -11,10 +11,9 @@
> #include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> +#include <linux/usb/tcpci.h>
> #include <linux/usb/tcpm.h>
>
> -#include "tcpci.h"
> -
> #define MT6360_REG_PHYCTRL1 0x80
> #define MT6360_REG_PHYCTRL3 0x82
> #define MT6360_REG_PHYCTRL7 0x86
> diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> index b56a0880a044..3291ca4948da 100644
> --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c
> @@ -10,9 +10,9 @@
> #include <linux/i2c.h>
> #include <linux/interrupt.h>
> #include <linux/gpio/consumer.h>
> +#include <linux/usb/tcpci.h>
> #include <linux/usb/tcpm.h>
> #include <linux/regmap.h>
> -#include "tcpci.h"
>
> #define RT1711H_VID 0x29CF
> #define RT1711H_PID 0x1711
> diff --git a/drivers/usb/typec/tcpm/tcpci.h b/include/linux/usb/tcpci.h
> similarity index 99%
> rename from drivers/usb/typec/tcpm/tcpci.h
> rename to include/linux/usb/tcpci.h
> index b2edd45f13c6..20c0bedb8ec8 100644
> --- a/drivers/usb/typec/tcpm/tcpci.h
> +++ b/include/linux/usb/tcpci.h
> @@ -9,6 +9,7 @@
> #define __LINUX_USB_TCPCI_H
>
> #include <linux/usb/typec.h>
> +#include <linux/usb/tcpm.h>
>
> #define TCPC_VENDOR_ID 0x0
> #define TCPC_PRODUCT_ID 0x2
On Tue, Jul 12, 2022 at 06:31:22AM -0700, Guenter Roeck wrote:
> On 7/12/22 02:05, Xin Ji wrote:
> > USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> > and a port controller (TCPC) - may require that the driver for the PD
> > controller accesses directly also the on-chip port controller in some cases.
> >
> > Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
> >
> > Reviewed-by: Guenter Roeck <[email protected]>
> > Reviewed-by: Heikki Krogerus <[email protected]>
> > Signed-off-by: Xin Ji <[email protected]>
> >
> > ---
> > V9 -> V10: Rebase on the latest code
> > V8 -> V9 : Add more commit message
> > V7 -> V8 : Fix Guanter's comment, remove unnecessary explain
>
> We are now at v16. The change log has not been updated since v10,
> making it all but worthless.
It's also already in my tree for a while, so I have no idea what this is
being generated against :(
On Tue, Jul 12, 2022 at 11:38:47AM +0200, Krzysztof Kozlowski wrote:
> On 12/07/2022 11:05, Xin Ji wrote:
> > Add analogix PD chip anx7411 device binding
> >
> > Reviewed-by: Rob Herring <[email protected]>
> > Signed-off-by: Xin Ji <[email protected]>
> >
> > ---
> > v13 -> v14 :
> > 1. Fix Robot compile error. Fix node name not correct.
>
> Node name is still not correct.
Hi Krzysztof, I'll add it.
Thanks,
Xin
>
> > 2. Change HEX to lowercase.
> > 3. Use "ports" property.
> > v12 -> v13 :
> > 1. Drop the quotes for "$id" and "$schema"
> > 2. Remove "allOf" label
> > 3. Change node name from "i2c1" to "i2c"
> > 4. Change node name from "typec" to "usb-typec"
> >
> > Signed-off-by: Xin Ji <[email protected]>
> > ---
> > .../bindings/usb/analogix,anx7411.yaml | 81 +++++++++++++++++++
> > 1 file changed, 81 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > new file mode 100644
> > index 000000000000..bbd071ba338f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fanalogix%2Canx7411.yaml%23&data=05%7C01%7Cxji%40analogixsemi.com%7Ccaae32a981aa4c347a8e08da63ea5518%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932155353583707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BGHo5E1W33sWfdhApWzq94%2F5TrDvfQc5lVF%2FSWl2m5A%3D&reserved=0
> > +$schema: https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cxji%40analogixsemi.com%7Ccaae32a981aa4c347a8e08da63ea5518%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932155353583707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7wG732uVpVNVjtxm14xiXKweazjop4xRTUe4HRZVTWM%3D&reserved=0
> > +
> > +title: Analogix ANX7411 Type-C controller bindings
> > +
> > +maintainers:
> > + - Xin Ji <[email protected]>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - analogix,anx7411
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + connector:
> > + type: object
> > + $ref: ../connector/usb-connector.yaml
> > + description:
> > + Properties for usb c connector.
> > +
> > + properties:
> > + compatible:
> > + const: usb-c-connector
> > +
> > + power-role: true
> > +
> > + data-role: true
> > +
> > + try-power-role: true
> > +
> > + required:
> > + - compatible
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - connector
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + anx7411@2c {
>
> Use generic node name:
> https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevicetree-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-basics.html%23generic-names-recommendation&data=05%7C01%7Cxji%40analogixsemi.com%7Ccaae32a981aa4c347a8e08da63ea5518%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932155353583707%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ACf4IGwVwtO7CsvL%2BYj4bbl%2BG88o5k6PyEyxZCl2as8%3D&reserved=0
>
> > + compatible = "analogix,anx7411";
> > + reg = <0x2c>;
> > + interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> > + interrupt-parent = <&gpio0>;
> > +
> > + typec_con: connector {
> > + compatible = "usb-c-connector";
> > + power-role = "dual";
> > + data-role = "dual";
> > + try-power-role = "source";
> > +
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@0 {
> > + reg = <0>;
> > + typec_con_ep: endpoint {
> > + remote-endpoint = <&usbotg_hs_ep>;
> > + };
> > + };
> > + };
> > + };
> > + };
> > + };
> > +...
>
>
> Best regards,
> Krzysztof
On Tue, Jul 12, 2022 at 03:43:48PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 12, 2022 at 06:31:22AM -0700, Guenter Roeck wrote:
> > On 7/12/22 02:05, Xin Ji wrote:
> > > USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> > > and a port controller (TCPC) - may require that the driver for the PD
> > > controller accesses directly also the on-chip port controller in some cases.
> > >
> > > Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
> > >
> > > Reviewed-by: Guenter Roeck <[email protected]>
> > > Reviewed-by: Heikki Krogerus <[email protected]>
> > > Signed-off-by: Xin Ji <[email protected]>
> > >
> > > ---
> > > V9 -> V10: Rebase on the latest code
> > > V8 -> V9 : Add more commit message
> > > V7 -> V8 : Fix Guanter's comment, remove unnecessary explain
> >
> > We are now at v16. The change log has not been updated since v10,
> > making it all but worthless.
>
> It's also already in my tree for a while, so I have no idea what this is
> being generated against :(
Hi all, I'm little confused, do I need update change log from v11 to
v16? There is no changes since v10.
Thanks,
Xin
On Wed, Jul 13, 2022 at 02:28:45PM +0800, Xin Ji wrote:
> On Tue, Jul 12, 2022 at 03:43:48PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jul 12, 2022 at 06:31:22AM -0700, Guenter Roeck wrote:
> > > On 7/12/22 02:05, Xin Ji wrote:
> > > > USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> > > > and a port controller (TCPC) - may require that the driver for the PD
> > > > controller accesses directly also the on-chip port controller in some cases.
> > > >
> > > > Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
> > > >
> > > > Reviewed-by: Guenter Roeck <[email protected]>
> > > > Reviewed-by: Heikki Krogerus <[email protected]>
> > > > Signed-off-by: Xin Ji <[email protected]>
> > > >
> > > > ---
> > > > V9 -> V10: Rebase on the latest code
> > > > V8 -> V9 : Add more commit message
> > > > V7 -> V8 : Fix Guanter's comment, remove unnecessary explain
> > >
> > > We are now at v16. The change log has not been updated since v10,
> > > making it all but worthless.
> >
> > It's also already in my tree for a while, so I have no idea what this is
> > being generated against :(
> Hi all, I'm little confused, do I need update change log from v11 to
> v16? There is no changes since v10.
I'm confused, why are you sending a patch over that is already in my
tree and in linux-next? You got an email saying it was merged, see
commit 7963d4d71011 ("usb: typec: tcpci: move tcpci.h to
include/linux/usb/").
thanks,
greg k-h
On Wed, Jul 13, 2022 at 08:36:53AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 13, 2022 at 02:28:45PM +0800, Xin Ji wrote:
> > On Tue, Jul 12, 2022 at 03:43:48PM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Jul 12, 2022 at 06:31:22AM -0700, Guenter Roeck wrote:
> > > > On 7/12/22 02:05, Xin Ji wrote:
> > > > > USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> > > > > and a port controller (TCPC) - may require that the driver for the PD
> > > > > controller accesses directly also the on-chip port controller in some cases.
> > > > >
> > > > > Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
> > > > >
> > > > > Reviewed-by: Guenter Roeck <[email protected]>
> > > > > Reviewed-by: Heikki Krogerus <[email protected]>
> > > > > Signed-off-by: Xin Ji <[email protected]>
> > > > >
> > > > > ---
> > > > > V9 -> V10: Rebase on the latest code
> > > > > V8 -> V9 : Add more commit message
> > > > > V7 -> V8 : Fix Guanter's comment, remove unnecessary explain
> > > >
> > > > We are now at v16. The change log has not been updated since v10,
> > > > making it all but worthless.
> > >
> > > It's also already in my tree for a while, so I have no idea what this is
> > > being generated against :(
> > Hi all, I'm little confused, do I need update change log from v11 to
> > v16? There is no changes since v10.
>
> I'm confused, why are you sending a patch over that is already in my
> tree and in linux-next? You got an email saying it was merged, see
> commit 7963d4d71011 ("usb: typec: tcpci: move tcpci.h to
> include/linux/usb/").
>
> thanks,
>
> greg k-h
Hi greg k-h, sorry for that, this serial has 3 patches, so I just think
need update all 3 patches in each upstream.
I'll only update the 2 patches next time.
Thanks,
Xin
On Wed, Jul 13, 2022 at 02:48:18PM +0800, Xin Ji wrote:
> On Wed, Jul 13, 2022 at 08:36:53AM +0200, Greg Kroah-Hartman wrote:
> > On Wed, Jul 13, 2022 at 02:28:45PM +0800, Xin Ji wrote:
> > > On Tue, Jul 12, 2022 at 03:43:48PM +0200, Greg Kroah-Hartman wrote:
> > > > On Tue, Jul 12, 2022 at 06:31:22AM -0700, Guenter Roeck wrote:
> > > > > On 7/12/22 02:05, Xin Ji wrote:
> > > > > > USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> > > > > > and a port controller (TCPC) - may require that the driver for the PD
> > > > > > controller accesses directly also the on-chip port controller in some cases.
> > > > > >
> > > > > > Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
> > > > > >
> > > > > > Reviewed-by: Guenter Roeck <[email protected]>
> > > > > > Reviewed-by: Heikki Krogerus <[email protected]>
> > > > > > Signed-off-by: Xin Ji <[email protected]>
> > > > > >
> > > > > > ---
> > > > > > V9 -> V10: Rebase on the latest code
> > > > > > V8 -> V9 : Add more commit message
> > > > > > V7 -> V8 : Fix Guanter's comment, remove unnecessary explain
> > > > >
> > > > > We are now at v16. The change log has not been updated since v10,
> > > > > making it all but worthless.
> > > >
> > > > It's also already in my tree for a while, so I have no idea what this is
> > > > being generated against :(
> > > Hi all, I'm little confused, do I need update change log from v11 to
> > > v16? There is no changes since v10.
> >
> > I'm confused, why are you sending a patch over that is already in my
> > tree and in linux-next? You got an email saying it was merged, see
> > commit 7963d4d71011 ("usb: typec: tcpci: move tcpci.h to
> > include/linux/usb/").
> >
> > thanks,
> >
> > greg k-h
> Hi greg k-h, sorry for that, this serial has 3 patches, so I just think
> need update all 3 patches in each upstream.
If you resend patches as part of a series, please explain in the change
log that this patch was unchanged.
Guenter