2022-07-13 07:23:40

by Tomer Maimon

[permalink] [raw]
Subject: [PATCH v2 0/2] iio: adc: npcm: add Arbel NPCM8XX support

This patch set adds Arbel NPCM8XX Analog-to-Digital Converter (ADC) support
to ADC NPCM driver.

The NPCM8XX ADC is a 12-bit converter for eight channel inputs.

The NPCM ADC driver tested on NPCM845 evaluation board.

Addressed comments from:
- Rob Herring : https://www.spinics.net/lists/kernel/msg4433755.html
- Krzysztof Kozlowski: https://www.spinics.net/lists/kernel/msg4434546.html
- Andy Shevchenko : https://www.spinics.net/lists/devicetree/msg516844.html

Changes since version 1:
- Modify dt-binding compatible property.
- Use device_get_match_data function instead of_match_node function.

Tomer Maimon (2):
dt-bindings: iio: adc: npcm: Add npcm845 compatible string
iio: adc: npcm: Add NPCM8XX support

.../bindings/iio/adc/nuvoton,npcm750-adc.yaml | 7 ++--
drivers/iio/adc/npcm_adc.c | 35 +++++++++++++++----
2 files changed, 33 insertions(+), 9 deletions(-)

--
2.33.0


2022-07-13 07:30:54

by Tomer Maimon

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: iio: adc: npcm: Add npcm845 compatible string

Add a compatible string for Nuvoton BMC NPCM845 ADC.

Signed-off-by: Tomer Maimon <[email protected]>
---
.../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
index 001cf263b7d5..fede2aa64092 100644
--- a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
@@ -10,11 +10,14 @@ maintainers:
- Tomer Maimon <[email protected]>

description:
- The NPCM ADC is a 10-bit converter for eight channel inputs.
+ The NPCM7XX ADC is a 10-bit converter and NPCM8XX ADC is a 12-bit converter,
+ both have eight channel inputs.

properties:
compatible:
- const: nuvoton,npcm750-adc
+ enum:
+ - nuvoton,npcm750-adc
+ - nuvoton,npcm845-adc

reg:
maxItems: 1
--
2.33.0

2022-07-13 08:42:16

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: npcm: Add npcm845 compatible string

On 13/07/2022 09:05, Tomer Maimon wrote:
> Add a compatible string for Nuvoton BMC NPCM845 ADC.
>
> Signed-off-by: Tomer Maimon <[email protected]>

I assume all properties from NPCM750 apply here as well:

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof