2022-07-13 16:32:53

by Stephen Kitt

[permalink] [raw]
Subject: [PATCH] arch/x86/Kconfig: specify idle=poll instead of no-hlt

Commit 27be45700021 ("x86 idle: remove 32-bit-only "no-hlt" parameter,
hlt_works_ok flag") removed no-hlt, but CONFIG_APM still refers to
it. Suggest "idle=poll" instead, based on the commit message:

> If a user wants to avoid HLT, then "idle=poll"
> is much more useful, as it avoids invocation of HLT
> in idle, while "no-hlt" failed to do so.

Signed-off-by: Stephen Kitt <[email protected]>
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index a293a30e4cdd..bb4fa31bec4d 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2517,7 +2517,7 @@ menuconfig APM

1) make sure that you have enough swap space and that it is
enabled.
- 2) pass the "no-hlt" option to the kernel
+ 2) pass the "idle=poll" option to the kernel
3) switch on floating point emulation in the kernel and pass
the "no387" option to the kernel
4) pass the "floppy=nodma" option to the kernel

base-commit: 50fd82b3a9a9335df5d50c7ddcb81c81d358c4fc
--
2.31.1


2022-08-31 21:55:13

by tip-bot2 for Jacob Pan

[permalink] [raw]
Subject: [tip: x86/misc] x86/Kconfig: Specify idle=poll instead of no-hlt

The following commit has been merged into the x86/misc branch of tip:

Commit-ID: 7987448ffc34f41590bae5b28cd23ca0b8c93291
Gitweb: https://git.kernel.org/tip/7987448ffc34f41590bae5b28cd23ca0b8c93291
Author: Stephen Kitt <[email protected]>
AuthorDate: Wed, 13 Jul 2022 18:08:40 +02:00
Committer: Dave Hansen <[email protected]>
CommitterDate: Wed, 31 Aug 2022 14:43:36 -07:00

x86/Kconfig: Specify idle=poll instead of no-hlt

Commit 27be45700021 ("x86 idle: remove 32-bit-only "no-hlt" parameter,
hlt_works_ok flag") removed no-hlt, but CONFIG_APM still refers to
it. Suggest "idle=poll" instead, based on the commit message:

> If a user wants to avoid HLT, then "idle=poll"
> is much more useful, as it avoids invocation of HLT
> in idle, while "no-hlt" failed to do so.

Signed-off-by: Stephen Kitt <[email protected]>
Signed-off-by: Dave Hansen <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
arch/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index f9920f1..83b163a 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2569,7 +2569,7 @@ menuconfig APM

1) make sure that you have enough swap space and that it is
enabled.
- 2) pass the "no-hlt" option to the kernel
+ 2) pass the "idle=poll" option to the kernel
3) switch on floating point emulation in the kernel and pass
the "no387" option to the kernel
4) pass the "floppy=nodma" option to the kernel