2022-07-13 17:40:41

by Amit Kumar Mahapatra

[permalink] [raw]
Subject: [PATCH] spi: spi-cadence: Fix SPI NO Slave Select macro definition

From: Sai Krishna Potthuri <[email protected]>

Fix SPI NO Slave Select macro definition, when all the SPI CS bits
are high which means no slave is selected.

Fixes: 21b511ddee09 ("spi: spi-cadence: Fix SPI CS gets toggling sporadically")
Signed-off-by: Sai Krishna Potthuri <[email protected]>
Signed-off-by: Amit Kumar Mahapatra <[email protected]>
---
BRANCH: for-next
---
drivers/spi/spi-cadence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c
index 31d778e9d255..6a7f7df1e776 100644
--- a/drivers/spi/spi-cadence.c
+++ b/drivers/spi/spi-cadence.c
@@ -69,7 +69,7 @@
#define CDNS_SPI_BAUD_DIV_SHIFT 3 /* Baud rate divisor shift in CR */
#define CDNS_SPI_SS_SHIFT 10 /* Slave Select field shift in CR */
#define CDNS_SPI_SS0 0x1 /* Slave Select zero */
-#define CDNS_SPI_NOSS 0x3C /* No Slave select */
+#define CDNS_SPI_NOSS 0xF /* No Slave select */

/*
* SPI Interrupt Registers bit Masks
--
2.17.1


2022-07-20 16:01:59

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: spi-cadence: Fix SPI NO Slave Select macro definition

On Wed, Jul 13, 2022 at 10:15:29PM +0530, Amit Kumar Mahapatra wrote:
> From: Sai Krishna Potthuri <[email protected]>
>
> Fix SPI NO Slave Select macro definition, when all the SPI CS bits
> are high which means no slave is selected.

This doesn't apply against current code, please check and resend.


Attachments:
(No filename) (332.00 B)
signature.asc (499.00 B)
Download all attachments

2022-07-20 22:06:38

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] spi: spi-cadence: Fix SPI NO Slave Select macro definition

On Wed, 13 Jul 2022 22:15:29 +0530, Amit Kumar Mahapatra wrote:
> From: Sai Krishna Potthuri <[email protected]>
>
> Fix SPI NO Slave Select macro definition, when all the SPI CS bits
> are high which means no slave is selected.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-cadence: Fix SPI NO Slave Select macro definition
commit: e1502ba41699736c578ba9d61ae6285d49f6921b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark