2022-07-13 18:33:26

by Khalid Masum

[permalink] [raw]
Subject: [RFC PATCH 0/1][RESEND] Fix KASAN: slab-out-of-bounds Read in sk_psock_get

Using size of sk_psock as the size for kcm_psock_cache size no longer
reproduces the issue. There might be a better way to solve this issue
though so I would like to ask for feedback.

The patch was sent to the wrong mailing list so resending it. Please
ignore the previous one.

Reported-and-tested-by: [email protected]
Link: https://syzkaller.appspot.com/bug?extid=1fa91bcd05206ff8cbb5

Khalid Masum (1):
net: kcm: Use sk_psock size for kcm_psock_cache

net/kcm/kcmsock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--
2.36.1


2022-07-13 19:07:55

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [RFC PATCH 0/1][RESEND] Fix KASAN: slab-out-of-bounds Read in sk_psock_get

On Thu, 14 Jul 2022 00:13:23 +0600 Khalid Masum wrote:
> Using size of sk_psock as the size for kcm_psock_cache size no longer
> reproduces the issue. There might be a better way to solve this issue
> though so I would like to ask for feedback.
>
> The patch was sent to the wrong mailing list so resending it. Please
> ignore the previous one.

What happened to my other off-list feedback?

I pointed you at another solution which was already being discussed -
does it solve the issue you're fixing?

2022-07-14 04:17:42

by Khalid Masum

[permalink] [raw]
Subject: Re: [RFC PATCH 0/1][RESEND] Fix KASAN: slab-out-of-bounds Read in sk_psock_get

On Thu, Jul 14, 2022 at 12:56 AM Jakub Kicinski <[email protected]> wrote:
>
> On Thu, 14 Jul 2022 00:13:23 +0600 Khalid Masum wrote:
> > Using size of sk_psock as the size for kcm_psock_cache size no longer
> > reproduces the issue. There might be a better way to solve this issue
> > though so I would like to ask for feedback.
> >
> > The patch was sent to the wrong mailing list so resending it. Please
> > ignore the previous one.
>
> What happened to my other off-list feedback?
>
> I pointed you at another solution which was already being discussed -
> does it solve the issue you're fixing?

Yes, this patch solves the issue I am fixing.

thanks,
Khalid Masum

2022-07-14 04:32:49

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [RFC PATCH 0/1][RESEND] Fix KASAN: slab-out-of-bounds Read in sk_psock_get

On Thu, 14 Jul 2022 09:55:18 +0600 Khalid Masum wrote:
> On Thu, Jul 14, 2022 at 12:56 AM Jakub Kicinski <[email protected]> wrote:
> > On Thu, 14 Jul 2022 00:13:23 +0600 Khalid Masum wrote:
> > > Using size of sk_psock as the size for kcm_psock_cache size no longer
> > > reproduces the issue. There might be a better way to solve this issue
> > > though so I would like to ask for feedback.
> > >
> > > The patch was sent to the wrong mailing list so resending it. Please
> > > ignore the previous one.
> >
> > What happened to my other off-list feedback?
> >
> > I pointed you at another solution which was already being discussed -
> > does it solve the issue you're fixing?
>
> Yes, this patch solves the issue I am fixing.

Thanks for checking! You can send your

Tested-by:

tag in reply to the most recent posting if you'd like:

https://lore.kernel.org/all/[email protected]/