2022-07-16 19:49:07

by Konrad Dybcio

Subject: [PATCH 1/2] dt-bindings: power: rpmpd: Add SM6375 power domains

Add the bindings for SM6375 RPMPDs.

Signed-off-by: Konrad Dybcio <[email protected]>
---
.../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
include/dt-bindings/power/qcom-rpmpd.h | 12 ++++++++++++
2 files changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index ad77a6380f38..8b58cbc298a1 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -39,6 +39,7 @@ properties:
- qcom,sm6115-rpmpd
- qcom,sm6125-rpmpd
- qcom,sm6350-rpmhpd
+ - qcom,sm6375-rpmpd
- qcom,sm8150-rpmhpd
- qcom,sm8250-rpmhpd
- qcom,sm8350-rpmhpd
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index 6cce5b7aa940..8b770bfcf46b 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -36,6 +36,18 @@
#define SM6350_MSS 4
#define SM6350_MX 5

+/* SM6350 Power Domain Indexes */
+#define SM6375_VDDCX 0
+#define SM6375_VDDCX_AO 1
+#define SM6375_VDDCX_VFL 2
+#define SM6375_VDDMX 3
+#define SM6375_VDDMX_AO 4
+#define SM6375_VDDMX_VFL 5
+#define SM6375_VDDGX 6
+#define SM6375_VDDGX_AO 7
+#define SM6375_VDD_LPI_CX 8
+#define SM6375_VDD_LPI_MX 9
+
/* SM8150 Power Domain Indexes */
#define SM8150_MSS 0
#define SM8150_EBI 1
--
2.37.0

2022-07-20 22:52:07

by Rob Herring (Arm)

Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Add SM6375 power domains

On Sat, 16 Jul 2022 21:32:00 +0200, Konrad Dybcio wrote:
> Add the bindings for SM6375 RPMPDs.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
> include/dt-bindings/power/qcom-rpmpd.h | 12 ++++++++++++
> 2 files changed, 13 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2022-07-21 10:18:07

by Marijn Suijten

Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Add SM6375 power domains

On 2022-07-16 21:32:00, Konrad Dybcio wrote:
> Add the bindings for SM6375 RPMPDs.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
> include/dt-bindings/power/qcom-rpmpd.h | 12 ++++++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> index ad77a6380f38..8b58cbc298a1 100644
> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
> @@ -39,6 +39,7 @@ properties:
> - qcom,sm6115-rpmpd
> - qcom,sm6125-rpmpd
> - qcom,sm6350-rpmhpd
> + - qcom,sm6375-rpmpd
> - qcom,sm8150-rpmhpd
> - qcom,sm8250-rpmhpd
> - qcom,sm8350-rpmhpd
> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
> index 6cce5b7aa940..8b770bfcf46b 100644
> --- a/include/dt-bindings/power/qcom-rpmpd.h
> +++ b/include/dt-bindings/power/qcom-rpmpd.h
> @@ -36,6 +36,18 @@
> #define SM6350_MSS 4
> #define SM6350_MX 5
>
> +/* SM6350 Power Domain Indexes */
> +#define SM6375_VDDCX 0
> +#define SM6375_VDDCX_AO 1
> +#define SM6375_VDDCX_VFL 2
> +#define SM6375_VDDMX 3
> +#define SM6375_VDDMX_AO 4
> +#define SM6375_VDDMX_VFL 5
> +#define SM6375_VDDGX 6
> +#define SM6375_VDDGX_AO 7
> +#define SM6375_VDD_LPI_CX 8
> +#define SM6375_VDD_LPI_MX 9

Looking at the naming/pattern of these constants I think they should
reside near the bottom of this file with SM6125 and friends, rather than
here with SM8150 and friends' MX/CX (and no _VFL).

- Marijn

> /* SM8150 Power Domain Indexes */
> #define SM8150_MSS 0
> #define SM8150_EBI 1
> --
> 2.37.0
>

2022-09-15 03:58:07

by Bjorn Andersson

Subject: Re: (subset) [PATCH 1/2] dt-bindings: power: rpmpd: Add SM6375 power domains

On Sat, 16 Jul 2022 21:32:00 +0200, Konrad Dybcio wrote:
> Add the bindings for SM6375 RPMPDs.
>
>

Applied, thanks!

[1/2] dt-bindings: power: rpmpd: Add SM6375 power domains
commit: 2d48e6ea3080ef7b2424dabfb500e29b030129d6
[2/2] soc: qcom: rpmpd: Add SM6375 support
commit: df646a17f103c6f18ab85c5e3773763d18dc528b

Best regards,
--
Bjorn Andersson <[email protected]>

2022-09-16 22:15:27

by Marijn Suijten

Subject: Re: (subset) [PATCH 1/2] dt-bindings: power: rpmpd: Add SM6375 power domains

On 2022-09-14 22:36:54, Bjorn Andersson wrote:
> On Sat, 16 Jul 2022 21:32:00 +0200, Konrad Dybcio wrote:
> > Add the bindings for SM6375 RPMPDs.
> >
> >
>
> Applied, thanks!
>
> [1/2] dt-bindings: power: rpmpd: Add SM6375 power domains
> commit: 2d48e6ea3080ef7b2424dabfb500e29b030129d6

It looks like my request [1] to move these rpmpd definitions from the
rpm*H*pd section of this file down to sit with the rest of the rpmpd
definitions hasn't made its way through?

> [2/2] soc: qcom: rpmpd: Add SM6375 support
> commit: df646a17f103c6f18ab85c5e3773763d18dc528b

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

- Marijn