2022-07-21 16:45:41

by Jason Wang

[permalink] [raw]
Subject: [PATCH 1/3] mmc: sdhci-acpi: Fix comment typo

The double `the' is duplicated in the comment, remove one.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/mmc/host/sdhci-acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index 4cca4c90769b..bddfaba091a9 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -648,7 +648,7 @@ static int sdhci_acpi_emmc_amd_probe_slot(struct platform_device *pdev,
* in reading a garbage value and using the wrong presets.
*
* Since HS400 and HS200 presets must be identical, we could
- * instead use the the SDR104 preset register.
+ * instead use the SDR104 preset register.
*
* If the above issues are resolved we could remove this quirk for
* firmware that that has valid presets (i.e., SDR12 <= 12 MHz).
--
2.35.1


2022-07-21 16:45:49

by Jason Wang

[permalink] [raw]
Subject: [PATCH 2/3] mmc: sdhci-esdhc-imx: Fix comment typo

The double `the' is duplicated in the comment, remove one.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/mmc/host/sdhci-esdhc-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index 55981b0f0b10..e1ada9487a8f 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -1454,7 +1454,7 @@ static void sdhci_esdhc_imx_hwinit(struct sdhci_host *host)
/*
* On i.MX8MM, we are running Dual Linux OS, with 1st Linux using SD Card
* as rootfs storage, 2nd Linux using eMMC as rootfs storage. We let the
- * the 1st linux configure power/clock for the 2nd Linux.
+ * 1st linux configure power/clock for the 2nd Linux.
*
* When the 2nd Linux is booting into rootfs stage, we let the 1st Linux
* to destroy the 2nd linux, then restart the 2nd linux, we met SDHCI dump.
--
2.35.1

2022-07-21 17:13:06

by Jason Wang

[permalink] [raw]
Subject: [PATCH 3/3] mmc: sdhci-omap: Fix comment typo

The double `any' is duplicated in the comment, remove one.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/mmc/host/sdhci-omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
index 033be559a730..8ed9256b83da 100644
--- a/drivers/mmc/host/sdhci-omap.c
+++ b/drivers/mmc/host/sdhci-omap.c
@@ -370,7 +370,7 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode)

/*
* Stage 1: Search for a maximum pass window ignoring any
- * any single point failures. If the tuning value ends up
+ * single point failures. If the tuning value ends up
* near it, move away from it in stage 2 below
*/
while (phase_delay <= MAX_PHASE_DELAY) {
--
2.35.1

2022-07-22 09:54:58

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH 1/3] mmc: sdhci-acpi: Fix comment typo

On Thu, 21 Jul 2022 at 18:30, Jason Wang <[email protected]> wrote:
>
> The double `the' is duplicated in the comment, remove one.
>

Hi Jason, these spelling fixups are getting somewhat annoying to me,
sorry. Don't get me wrong, it's nice to have good readable comments,
but the patches don't really need to be one line of change per patch.
Could you perhaps look over all mmc host drivers and fix all spelling
mistakes in them and send one patch to cover all of them instead?

Kind regards
Uffe

> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/mmc/host/sdhci-acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
> index 4cca4c90769b..bddfaba091a9 100644
> --- a/drivers/mmc/host/sdhci-acpi.c
> +++ b/drivers/mmc/host/sdhci-acpi.c
> @@ -648,7 +648,7 @@ static int sdhci_acpi_emmc_amd_probe_slot(struct platform_device *pdev,
> * in reading a garbage value and using the wrong presets.
> *
> * Since HS400 and HS200 presets must be identical, we could
> - * instead use the the SDR104 preset register.
> + * instead use the SDR104 preset register.
> *
> * If the above issues are resolved we could remove this quirk for
> * firmware that that has valid presets (i.e., SDR12 <= 12 MHz).
> --
> 2.35.1
>