2022-07-18 07:26:38

by Youlin Li

Subject: [PATCH] bpf: Fix typo in comments in verifier

Replace 'then' with 'than'.

Fixes: f4d7e40a5b71 ("bpf: introduce function calls (verification)")
Signed-off-by: Kuee K1r0a <[email protected]>
---
kernel/bpf/verifier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 0efbac0fd126..4da1a7c7657a 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -1167,7 +1167,7 @@ static int copy_verifier_state(struct bpf_verifier_state *dst_state,
return -ENOMEM;
dst_state->jmp_history_cnt = src->jmp_history_cnt;

- /* if dst has more stack frames then src frame, free them */
+ /* if dst has more stack frames than src frame, free them */
for (i = src->curframe + 1; i <= dst_state->curframe; i++) {
free_func_state(dst_state->frame[i]);
dst_state->frame[i] = NULL;
--
2.25.1

2022-07-18 16:22:41

by Daniel Müller

Subject: Re: [PATCH] bpf: Fix typo in comments in verifier

On Mon, Jul 18, 2022 at 02:52:31PM +0800, Kuee K1r0a wrote:
> Replace 'then' with 'than'.
>
> Fixes: f4d7e40a5b71 ("bpf: introduce function calls (verification)")
> Signed-off-by: Kuee K1r0a <[email protected]>
> ---
> kernel/bpf/verifier.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 0efbac0fd126..4da1a7c7657a 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -1167,7 +1167,7 @@ static int copy_verifier_state(struct bpf_verifier_state *dst_state,
> return -ENOMEM;
> dst_state->jmp_history_cnt = src->jmp_history_cnt;
>
> - /* if dst has more stack frames then src frame, free them */
> + /* if dst has more stack frames than src frame, free them */

Should we use plural as well, 'src frames'?

[...]

I believe the patch prefix should indicate which branch the patch targets as
well. E.g., [PATCH bpf-next]. Looks good to me otherwise.

Acked-by: Daniel M?ller <[email protected]>