Add the ACPI Kconfig dependency that was missed during the initial
driver submission. Fixes the following compiler errors:
drivers/platform/chrome/cros_typec_switch.c:93:9: error: call to
undeclared function 'acpi_evaluate_integer'; ISO C99 and later do not
support implicit function declarations
[-Wimplicit-function-declaration]
ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
drivers/platform/chrome/cros_typec_switch.c:93:35: error: incomplete
definition of type 'struct acpi_device'
ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
Fixes: e54369058f3d ("platform/chrome: cros_typec_switch: Add switch driver")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Prashant Malani <[email protected]>
---
Changes since v1:
- Correct the malformed Reported-by tag. No functional changes.
(Apologies for the quick respin.)
drivers/platform/chrome/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index c62a514a087f..9d4fc505fa25 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -267,7 +267,7 @@ config CHROMEOS_PRIVACY_SCREEN
config CROS_TYPEC_SWITCH
tristate "ChromeOS EC Type-C Switch Control"
- depends on MFD_CROS_EC_DEV && TYPEC
+ depends on MFD_CROS_EC_DEV && TYPEC && ACPI
default MFD_CROS_EC_DEV
help
If you say Y here, you get support for configuring the Chrome OS EC Type C
--
2.37.0.170.g444d1eabd0-goog
On Mon, Jul 18, 2022 at 09:27:55PM +0000, Prashant Malani wrote:
> Add the ACPI Kconfig dependency that was missed during the initial
> driver submission. Fixes the following compiler errors:
>
> drivers/platform/chrome/cros_typec_switch.c:93:9: error: call to
> undeclared function 'acpi_evaluate_integer'; ISO C99 and later do not
> support implicit function declarations
> [-Wimplicit-function-declaration]
> ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
>
> drivers/platform/chrome/cros_typec_switch.c:93:35: error: incomplete
> definition of type 'struct acpi_device'
> ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
>
> Fixes: e54369058f3d ("platform/chrome: cros_typec_switch: Add switch driver")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Prashant Malani <[email protected]>
> ---
>
> Changes since v1:
> - Correct the malformed Reported-by tag. No functional changes.
> (Apologies for the quick respin.)
I already have v1 in my tree, so this isn't going to work, sorry.
greg k-h
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Greg Kroah-Hartman <[email protected]>:
On Mon, 18 Jul 2022 21:27:55 +0000 you wrote:
> Add the ACPI Kconfig dependency that was missed during the initial
> driver submission. Fixes the following compiler errors:
>
> drivers/platform/chrome/cros_typec_switch.c:93:9: error: call to
> undeclared function 'acpi_evaluate_integer'; ISO C99 and later do not
> support implicit function declarations
> [-Wimplicit-function-declaration]
> ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
>
> [...]
Here is the summary with links:
- [v2] platform/chrome: cros_typec_switch: Add ACPI Kconfig dep
https://git.kernel.org/chrome-platform/c/88a15fbb47db
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Greg Kroah-Hartman <[email protected]>:
On Mon, 18 Jul 2022 21:27:55 +0000 you wrote:
> Add the ACPI Kconfig dependency that was missed during the initial
> driver submission. Fixes the following compiler errors:
>
> drivers/platform/chrome/cros_typec_switch.c:93:9: error: call to
> undeclared function 'acpi_evaluate_integer'; ISO C99 and later do not
> support implicit function declarations
> [-Wimplicit-function-declaration]
> ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
>
> [...]
Here is the summary with links:
- [v2] platform/chrome: cros_typec_switch: Add ACPI Kconfig dep
https://git.kernel.org/chrome-platform/c/88a15fbb47db
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html