2022-07-19 15:09:55

by Artem Borisov

Subject: [PATCH] HID: alps: Declare U1_UNICORN_LEGACY support

U1_UNICORN_LEGACY id was added to the driver, but was not declared
in the device id table, making it impossible to use.

Fixes: 640e403 ("HID: alps: Add AUI1657 device ID")
Signed-off-by: Artem Borisov <[email protected]>
---
drivers/hid/hid-alps.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 2b986d0dbde4..db146d0f7937 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -830,6 +830,8 @@ static const struct hid_device_id alps_id[] = {
USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1) },
+ { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
+ USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_UNICORN_LEGACY) },
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_T4_BTNLESS) },
{ }
--
2.20.1

2022-07-22 13:15:56

by Jiri Kosina

Subject: Re: [PATCH] HID: alps: Declare U1_UNICORN_LEGACY support

On Tue, 19 Jul 2022, Artem Borisov wrote:

> U1_UNICORN_LEGACY id was added to the driver, but was not declared
> in the device id table, making it impossible to use.
>
> Fixes: 640e403 ("HID: alps: Add AUI1657 device ID")
> Signed-off-by: Artem Borisov <[email protected]>
> ---
> drivers/hid/hid-alps.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
> index 2b986d0dbde4..db146d0f7937 100644
> --- a/drivers/hid/hid-alps.c
> +++ b/drivers/hid/hid-alps.c
> @@ -830,6 +830,8 @@ static const struct hid_device_id alps_id[] = {
> USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
> USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1) },
> + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
> + USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_UNICORN_LEGACY) },
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
> USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_T4_BTNLESS) },
> { }

Applied, thanks.

--
Jiri Kosina
SUSE Labs