2022-07-19 16:17:47

by Andrey Strachuk

Subject: [PATCH] staging: rtl8723bs: remove useless comparison in _rtw_reg_apply_flags()

Local variable 'ch' is initialized by an address
of field of ieee80211_supported_band structure, so it does
not make sense to compare 'ch' with NULL.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Strachuk <[email protected]>
Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
---
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
index 5eef1d68c6f0..62fbf9e1b849 100644
--- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
+++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c
@@ -74,8 +74,7 @@ static void _rtw_reg_apply_flags(struct wiphy *wiphy)
for (j = 0; j < sband->n_channels; j++) {
ch = &sband->channels[j];

- if (ch)
- ch->flags = IEEE80211_CHAN_DISABLED;
+ ch->flags = IEEE80211_CHAN_DISABLED;
}
}
}
--
2.25.1

2022-07-27 06:45:25

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8723bs: remove useless comparison in _rtw_reg_apply_flags()

On Tue, Jul 19, 2022 at 06:53:09PM +0300, Andrey Strachuk wrote:
> Local variable 'ch' is initialized by an address
> of field of ieee80211_supported_band structure, so it does
> not make sense to compare 'ch' with NULL.

Where is it initialized with an address? You need to document this
here.

>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Strachuk <[email protected]>
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")

This is not a bug fix, but a code optimization, so no need for this
Fixes: tag.

thanks,

greg k-h