2022-07-20 11:10:53

by Xin Gao

Subject: [PATCH] m68k/mac: Fixed duplicate "in" in comments.

Fixed duplicate "in" in comments.

Signed-off-by: Xin Gao <[email protected]>
---
arch/m68k/mac/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/mac/misc.c b/arch/m68k/mac/misc.c
index 4fab34791758..29a4cb46af01 100644
--- a/arch/m68k/mac/misc.c
+++ b/arch/m68k/mac/misc.c
@@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)

reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);

- /* The bits of the byte go in in MSB order */
+ /* The bits of the byte go in MSB order */

for (i = 0 ; i < 8 ; i++) {
bit = data & 0x80? 1 : 0;
--
2.30.2

2022-07-20 18:38:43

by Geert Uytterhoeven

Subject: Re: [PATCH] m68k/mac: Fixed duplicate "in" in comments.

Hi Xin,

On Wed, Jul 20, 2022 at 12:55 PM Xin Gao <[email protected]> wrote:
> Fixed duplicate "in" in comments.
>
> Signed-off-by: Xin Gao <[email protected]>

Thanks for your patch!

> --- a/arch/m68k/mac/misc.c
> +++ b/arch/m68k/mac/misc.c
> @@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)
>
> reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);
>
> - /* The bits of the byte go in in MSB order */
> + /* The bits of the byte go in MSB order */

The original was correct.
Ask yourself the question: "How should the bits go in?"
"In MSB order".

>
> for (i = 0 ; i < 8 ; i++) {
> bit = data & 0x80? 1 : 0;

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds