2022-07-20 20:11:48

by Xin Gao

Subject: [PATCH] mtd:do not initialise statics to 0.

do not initialise statics to 0.

Signed-off-by: Xin Gao <[email protected]>
---
drivers/mtd/maps/scx200_docflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/maps/scx200_docflash.c b/drivers/mtd/maps/scx200_docflash.c
index 8462662b7128..a565d69d28d6 100644
--- a/drivers/mtd/maps/scx200_docflash.c
+++ b/drivers/mtd/maps/scx200_docflash.c
@@ -24,7 +24,7 @@ MODULE_AUTHOR("Christer Weinigel <[email protected]>");
MODULE_DESCRIPTION("NatSemi SCx200 DOCCS Flash Driver");
MODULE_LICENSE("GPL");

-static int probe = 0; /* Don't autoprobe */
+static int probe; /* Don't autoprobe */
static unsigned size = 0x1000000; /* 16 MiB the whole ISA address space */
static unsigned width = 8; /* Default to 8 bits wide */
static char *flashtype = "cfi_probe";
--
2.30.2

2022-07-21 06:47:00

by Tudor Ambarus

Subject: Re: [PATCH] mtd:do not initialise statics to 0.

On 7/20/22 22:55, Xin Gao wrote:
> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> do not initialise statics to 0.

Please describe why. It may worth reading:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

>
> Signed-off-by: Xin Gao <[email protected]>
> ---
> drivers/mtd/maps/scx200_docflash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/maps/scx200_docflash.c b/drivers/mtd/maps/scx200_docflash.c
> index 8462662b7128..a565d69d28d6 100644
> --- a/drivers/mtd/maps/scx200_docflash.c
> +++ b/drivers/mtd/maps/scx200_docflash.c
> @@ -24,7 +24,7 @@ MODULE_AUTHOR("Christer Weinigel <[email protected]>");
> MODULE_DESCRIPTION("NatSemi SCx200 DOCCS Flash Driver");
> MODULE_LICENSE("GPL");
>
> -static int probe = 0; /* Don't autoprobe */
> +static int probe; /* Don't autoprobe */
> static unsigned size = 0x1000000; /* 16 MiB the whole ISA address space */
> static unsigned width = 8; /* Default to 8 bits wide */
> static char *flashtype = "cfi_probe";
> --
> 2.30.2
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/