2022-07-21 04:39:12

by Martin Kepplinger

Subject: [PATCH v5 1/3] PM: domain: fix indentation and use BIT macro for flags

Use the BIT macro for flags and simply do 2 tags indentation.

Signed-off-by: Martin Kepplinger <[email protected]>
---
include/linux/pm_domain.h | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
index ebc351698090..76bc9e3ef5ff 100644
--- a/include/linux/pm_domain.h
+++ b/include/linux/pm_domain.h
@@ -8,6 +8,7 @@
#ifndef _LINUX_PM_DOMAIN_H
#define _LINUX_PM_DOMAIN_H

+#include <linux/bits.h>
#include <linux/device.h>
#include <linux/ktime.h>
#include <linux/mutex.h>
@@ -61,13 +62,13 @@
* components' next wakeup when determining the
* optimal idle state.
*/
-#define GENPD_FLAG_PM_CLK (1U << 0)
-#define GENPD_FLAG_IRQ_SAFE (1U << 1)
-#define GENPD_FLAG_ALWAYS_ON (1U << 2)
-#define GENPD_FLAG_ACTIVE_WAKEUP (1U << 3)
-#define GENPD_FLAG_CPU_DOMAIN (1U << 4)
-#define GENPD_FLAG_RPM_ALWAYS_ON (1U << 5)
-#define GENPD_FLAG_MIN_RESIDENCY (1U << 6)
+#define GENPD_FLAG_PM_CLK BIT(0)
+#define GENPD_FLAG_IRQ_SAFE BIT(1)
+#define GENPD_FLAG_ALWAYS_ON BIT(2)
+#define GENPD_FLAG_ACTIVE_WAKEUP BIT(3)
+#define GENPD_FLAG_CPU_DOMAIN BIT(4)
+#define GENPD_FLAG_RPM_ALWAYS_ON BIT(5)
+#define GENPD_FLAG_MIN_RESIDENCY BIT(6)

enum gpd_status {
GENPD_STATE_ON = 0, /* PM domain is on */
--
2.30.2

2022-07-21 11:17:59

by Ulf Hansson

Subject: Re: [PATCH v5 1/3] PM: domain: fix indentation and use BIT macro for flags

On Thu, 21 Jul 2022 at 06:36, Martin Kepplinger
<[email protected]> wrote:
>
> Use the BIT macro for flags and simply do 2 tags indentation.
>
> Signed-off-by: Martin Kepplinger <[email protected]>

I prefer to keep the advantages with doing a git blame on this file,
over this cleanup. Unless you feel strongly about this I would
appreciate it if you can drop $subject patch from the series.

Kind regards
Uffe

> ---
> include/linux/pm_domain.h | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> index ebc351698090..76bc9e3ef5ff 100644
> --- a/include/linux/pm_domain.h
> +++ b/include/linux/pm_domain.h
> @@ -8,6 +8,7 @@
> #ifndef _LINUX_PM_DOMAIN_H
> #define _LINUX_PM_DOMAIN_H
>
> +#include <linux/bits.h>
> #include <linux/device.h>
> #include <linux/ktime.h>
> #include <linux/mutex.h>
> @@ -61,13 +62,13 @@
> * components' next wakeup when determining the
> * optimal idle state.
> */
> -#define GENPD_FLAG_PM_CLK (1U << 0)
> -#define GENPD_FLAG_IRQ_SAFE (1U << 1)
> -#define GENPD_FLAG_ALWAYS_ON (1U << 2)
> -#define GENPD_FLAG_ACTIVE_WAKEUP (1U << 3)
> -#define GENPD_FLAG_CPU_DOMAIN (1U << 4)
> -#define GENPD_FLAG_RPM_ALWAYS_ON (1U << 5)
> -#define GENPD_FLAG_MIN_RESIDENCY (1U << 6)
> +#define GENPD_FLAG_PM_CLK BIT(0)
> +#define GENPD_FLAG_IRQ_SAFE BIT(1)
> +#define GENPD_FLAG_ALWAYS_ON BIT(2)
> +#define GENPD_FLAG_ACTIVE_WAKEUP BIT(3)
> +#define GENPD_FLAG_CPU_DOMAIN BIT(4)
> +#define GENPD_FLAG_RPM_ALWAYS_ON BIT(5)
> +#define GENPD_FLAG_MIN_RESIDENCY BIT(6)
>
> enum gpd_status {
> GENPD_STATE_ON = 0, /* PM domain is on */
> --
> 2.30.2
>