2022-07-21 15:10:56

by Abhijeet Srivastava

Subject: [PATCH] media: staging: media: zoran: Removed braces for single statement block

Warning found by checkpatch.pl script.

Signed-off-by: Abhijeet Srivastava <[email protected]>
---
drivers/staging/media/zoran/zoran_card.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c
index 26f978a1cc72..0c138d47d0c3 100644
--- a/drivers/staging/media/zoran/zoran_card.c
+++ b/drivers/staging/media/zoran/zoran_card.c
@@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
BUZ_NUM_STAT_COM * sizeof(u32),
&zr->p_sc, GFP_KERNEL);
- if (!zr->stat_com) {
+ if (!zr->stat_com)
return -ENOMEM;
- }
+
for (j = 0; j < BUZ_NUM_STAT_COM; j++)
zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to zr36057 */

--
2.34.1

2022-07-22 05:11:28

by Philipp Hortmann

Subject: Re: [PATCH] media: staging: media: zoran: Removed braces for single statement block

On 7/21/22 17:00, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet Srivastava <[email protected]>
> ---
> drivers/staging/media/zoran/zoran_card.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c
> index 26f978a1cc72..0c138d47d0c3 100644
> --- a/drivers/staging/media/zoran/zoran_card.c
> +++ b/drivers/staging/media/zoran/zoran_card.c
> @@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
> zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
> BUZ_NUM_STAT_COM * sizeof(u32),
> &zr->p_sc, GFP_KERNEL);
> - if (!zr->stat_com) {
> + if (!zr->stat_com)
> return -ENOMEM;
> - }
> +
> for (j = 0; j < BUZ_NUM_STAT_COM; j++)
> zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to zr36057 */
>


Why does the subject line start with "media:" The subsystem is
"staging:" so the subject should start with "staging: media: ..."

I have no clue if this is accepted.

Regards,

Philipp

2022-08-24 10:24:16

by Hans Verkuil

Subject: Re: [PATCH] media: staging: media: zoran: Removed braces for single statement block

Hi Abhijeet,

Thank you for the zoran patches, unfortunately these are a duplicate of

https://patchwork.linuxtv.org/project/linux-media/patch/[email protected]/

I wish I'd noticed your patches earlier, it would have saved me some work :-(

I'm marking your patches Obsoleted in patchwork.

Regards,

Hans

On 21/07/2022 17:00, Abhijeet Srivastava wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Abhijeet Srivastava <[email protected]>
> ---
> drivers/staging/media/zoran/zoran_card.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c
> index 26f978a1cc72..0c138d47d0c3 100644
> --- a/drivers/staging/media/zoran/zoran_card.c
> +++ b/drivers/staging/media/zoran/zoran_card.c
> @@ -1038,9 +1038,9 @@ static int zr36057_init(struct zoran *zr)
> zr->stat_com = dma_alloc_coherent(&zr->pci_dev->dev,
> BUZ_NUM_STAT_COM * sizeof(u32),
> &zr->p_sc, GFP_KERNEL);
> - if (!zr->stat_com) {
> + if (!zr->stat_com)
> return -ENOMEM;
> - }
> +
> for (j = 0; j < BUZ_NUM_STAT_COM; j++)
> zr->stat_com[j] = cpu_to_le32(1); /* mark as unavailable to zr36057 */
>